Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sensitive cases #69

Draft
wants to merge 27 commits into
base: master
Choose a base branch
from
Draft

Conversation

alexkunde
Copy link
Contributor

@alexkunde alexkunde commented Jun 21, 2023

New Feature: case sensitive parsing of LS_COLORS

disclaimer: it looks like a lot of changes, it is, but thats due to the fact that its based on another PR

...

Copy link
Contributor

@tavianator tavianator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm this is interesting. My understanding was that GNU ls was always ASCII-case-insensitive on matching extensions. But it looks like that only changed in 2018: coreutils/coreutils@24053fb.

As of March 2023 they now do a "smart case" type thing: coreutils/coreutils@47988fa

src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
@alexkunde
Copy link
Contributor Author

The test mentioned is also the one I worked on to succeed. btw, it wont since nu-ansi-term seems to not keep the color codes ordered.

@fdncred
Copy link
Contributor

fdncred commented Jun 25, 2023

it wont since nu-ansi-term seems to not keep the color codes ordered.

if there's a particular order they're supposed to be in, we at nu-ansi-term, would probably accept a PR for this ordering.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants