Allow dimensional arguments for atan2 - part 2 #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imacg
changed the title
|
I have rebased the branch in your original PR. That is why the two first commits show up again (and it shows that it cannot be merged). It is usually best to synchronize your fork first. Do you want to try to fix this on your own (rebase your changes on my master branch, let me know if you need any help with Git)? If not, I can also fix it myself. |
|
I've rebased my branch onto of your master. |
|
Thanks! |
|
My pleasure. Thanks for your help and patience. |
|
Released as v7.2.0. Congrats on your first open source contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for bug introduced by original PR and tests covering atan2.
Original PR #31