Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to PureScript 0.15.0 #55

Merged
merged 1 commit into from
May 12, 2022
Merged

Conversation

triallax
Copy link
Contributor

@triallax triallax commented May 3, 2022

No description provided.

@triallax triallax marked this pull request as ready for review May 9, 2022 15:47
@triallax
Copy link
Contributor Author

triallax commented May 10, 2022

@sharkdp this PR is ready now (just commenting in case you didn't get a notification, did you?).

@sharkdp sharkdp merged commit 4af8dab into sharkdp:master May 12, 2022
@sharkdp
Copy link
Owner

sharkdp commented May 12, 2022

Thank you!

@triallax triallax deleted the update-to-0.15.0 branch May 12, 2022 10:55
@triallax
Copy link
Contributor Author

Can you cut a new release so I can readd purescript-quantities to the package set?

@sharkdp
Copy link
Owner

sharkdp commented May 15, 2022

I tried to follow the steps here: https://github.com/purescript/spago#publish-my-library

Bumping the version went fine (I pushed the changes and created a GitHub release), but pulp publish fails with:

▶ pulp publish
* ERROR: ENOENT: no such file or directory, scandir 'bower_components'

If I do bower install, resolve a lot of conflicts manually, pulp publish complains with "working tree dirty" (bower_components is not .gitignored).

@triallax
Copy link
Contributor Author

Sorry, I lack the knowledge to help you. Perhaps you might get help on the PureScript Discourse or on Spago's issue tracker?

@JordanMartinez
Copy link

Try doing this

rm -rf bower_components/
bower cache clean
bower install

If the bower_components dir already exists, sometimes bower thinks it should use those versions instead of wiping it out completely. Also sometimes the bower cache gets in the way.

@sharkdp
Copy link
Owner

sharkdp commented May 16, 2022

@JordanMartinez Thank you very much. It doesn't help, unfortunately. After rm -rf bower_components; bower cache clean:

> bower install
bower not-cached    https://github.com/sharkdp/purescript-decimals.git#^v7.0.0
bower resolve       https://github.com/sharkdp/purescript-decimals.git#^v7.0.0
bower not-cached    https://github.com/sharkdp/purescript-numbers.git#^v9.0.0
bower resolve       https://github.com/sharkdp/purescript-numbers.git#^v9.0.0
bower not-cached    https://github.com/paf31/purescript-lists.git#^v7.0.0
bower resolve       https://github.com/paf31/purescript-lists.git#^v7.0.0
bower not-cached    https://github.com/garyb/purescript-newtype.git#^v5.0.0
bower resolve       https://github.com/garyb/purescript-newtype.git#^v5.0.0
…
bower extract       purescript-exists#^6.0.0 archive.tar.gz
bower resolved      https://github.com/paf31/purescript-exists.git#6.0.0
bower extract       purescript-exists#^5.0.0 archive.tar.gz
bower resolved      https://github.com/paf31/purescript-exists.git#5.1.0

Unable to find a suitable version for purescript-foldable-traversable, please choose one by typing one of the numbers below:
    1) purescript-foldable-traversable#^5.0.0 which resolved to 5.0.1 and is required by purescript-arrays#6.0.1, purescript-gen#3.0.0, purescript-lazy#5.0.0, purescript-lists#6.1.0, purescript-nonempty#6.1.0, purescript-pairs#8.0.0, purescript-quickcheck#7.1.0, purescript-strings#5.0.0, purescript-transformers#5.2.0, purescript-unfoldable#5.0.0
    2) purescript-foldable-traversable#^6.0.0 which resolved to 6.0.0 and is required by purescript-lazy#6.0.0, purescript-lists#7.0.0, purescript-nonempty#7.0.0, purescript-unfoldable#6.0.0
    3) purescript-foldable-traversable#^v6.0.0 which resolved to 6.0.0 and is required by purescript-quantities

Prefix the choice with ! to persist it to bower.json

? Answer 

If I answer these questions, there are many others popping up afterwards...

@triallax
Copy link
Contributor Author

triallax commented May 17, 2022

Maybe it has something to do with purescript-pairs's bower.json? The versions in the file seem to be outdated.

@JordanMartinez
Copy link

JordanMartinez commented May 17, 2022

That's it! See how it depends on foldable-traversable@5.0.0 but here we depend on foldable-traversable@6.0.0? pairs needs to be updated before this repo's docs can be published.

triallax added a commit to triallax/purescript-pairs that referenced this pull request May 17, 2022
sharkdp pushed a commit to sharkdp/purescript-pairs that referenced this pull request May 17, 2022
@sharkdp
Copy link
Owner

sharkdp commented May 17, 2022

Awesome - thank you guys! We now have a proper new version: https://pursuit.purescript.org/packages/purescript-quantities/12.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants