Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new core filetypes for STICKY/OTHER_WRITABLE/STICKY_OTHER_WRITABL… #34

Merged
merged 1 commit into from
Feb 28, 2020

Conversation

mattbalvin
Copy link
Contributor

These flags are set inside of WSL on directories mapped in from the Windows host OS
and default to an ugly/unreadable green background for numerous files in Ubuntu and
possibly other WSL supported distributions.

Added core filetype definitions for these file types and updated the themes to add a
blank LS_COLORS entry for each type which alleviates the theme breaking default
background color for WSL.

Please let me know if you need anything changed/tested to incorporate this change. Thank you!

…E flags

These flags are set inside of WSL on directories mapped in from the Windows host OS
and default to an ugly/unreadable green background for numerous files in Ubuntu and
possibly other WSL supported distributions.

Added core filetype definitions for these file types and updated the themes to add a
blank LS_COLORS entry for each type which alleviates the theme breaking default
background color for WSL.
@sharkdp
Copy link
Owner

sharkdp commented Feb 28, 2020

Thank you very much!

Looks like this supersedes #29.

Leaving the style as default for now is fine for me. However, I could also imagine that we want to mark (sticky +) other-writeable folders like /tmp with a (nice) background color. For example:

molokai.yml:

  other_writable:
    background: cyan
    foreground: black

image

@sharkdp sharkdp merged commit c891db1 into sharkdp:master Feb 28, 2020
@mattbalvin
Copy link
Contributor Author

mattbalvin commented Feb 29, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants