Fixes related to compiling on OSX #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 24, 2016 11:47
Without this, clang/gcc on Mac OSX will fail to build because it thinks that the .h files are to be precompiled-headers.
When compiling with clang/gcc the following warning is emitted:
warning: comparison of constant -1 with expression of type 'uint16_t'
(aka 'unsigned short') is always false
[-Wtautological-constant-out-of-range-compare]
Changing received_bytes to match the return type of recvfrom() resolves
this warning and also requires changing the format statements within
the printf() calls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling on OSX, the Makefile needed to be changed because clang's emulation of gcc was not happy with the 'common/*' inclusion.
In addition, clang giving a warning that the conditional checks where the output of recvfrom() was assigned to the unsigned-integer received_bytes and then checked against -1...and thus would have no effect.