Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Impl reader bit order #367

Closed
wants to merge 8 commits into from
Closed

WIP: Impl reader bit order #367

wants to merge 8 commits into from

Conversation

wcampbell0x2a
Copy link
Collaborator

Reading looks to be working!

@github-actions
Copy link

Benchmark for 5632aa3

Click to view benchmark
Test Base PR %
deku_read_bits 1678.4±1.55ns 1691.3±0.64ns +0.77%
deku_read_byte 26.0±0.27ns 27.2±0.12ns +4.62%
deku_read_enum 11.2±0.08ns 12.6±0.01ns +12.50%
deku_read_vec 66.9±0.28ns 60.5±0.10ns -9.57%
deku_write_bits 162.1±0.14ns 164.9±0.22ns +1.73%
deku_write_byte 172.3±0.55ns 174.3±0.52ns +1.16%
deku_write_enum 114.5±0.44ns 116.8±0.59ns +2.01%
deku_write_vec 4.3±0.01µs 4.6±0.01µs +6.98%

This was referenced Oct 24, 2023
Open
Open
@wcampbell0x2a
Copy link
Collaborator Author

Replaced with #373

@wcampbell0x2a wcampbell0x2a deleted the impl-reader-bit-order branch November 3, 2023 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@wcampbell0x2a