-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve performance after impl-writer
and impl-reader
#393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
impl-writer
and impl-reader
Benchmark for f3b1791Click to view benchmark
|
ac27ad8
to
f8aacce
Compare
Merged
b584273
to
6610a40
Compare
Benchmark for 86622b5Click to view benchmark
|
ce32ad7
to
9af390b
Compare
ee48236
to
d2e5882
Compare
Benchmark for 0025238Click to view benchmark
|
9af390b
to
157add8
Compare
d2e5882
to
33b7e1e
Compare
Benchmark for c5051aeClick to view benchmark
|
7297dc4
to
26c00d3
Compare
33b7e1e
to
dbb3849
Compare
Benchmark for 2210022Click to view benchmark
|
16aef36
to
3bb6e31
Compare
dbb3849
to
303edc7
Compare
Benchmark for 9aa4243Click to view benchmark
|
Benchmark for f704391Click to view benchmark
|
Benchmark for b328835Click to view benchmark
|
sharksforarms
previously approved these changes
Apr 29, 2024
The base branch was changed.
6c78f99
to
176383a
Compare
Benchmark for b6b2884Click to view benchmark
|
@sharksforarms rebased, should be good now |
sharksforarms
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes most performance issues where the rustc compiler in different version with different parameters didn't inline several functions, both generated and
impl
'ed in deku.See wcampbell0x2a/deku-bench#6 for benchmarks. Speaking of which I will probably add these benchmarks directly into this project at some point.
I actually opened a ticked for
rust-lang
, since the nightly changes regressed the performance of this crate, until this commit was added: rust-lang/rust#118674This might removed the need for testing: #358, and discussed with #308 (comment).
See #25