Added new static port information for TechnicLargeLinearMotor

[mennolodder]

This is the last issue to fix #193

[tthiery]

Hi @mennolodder

for this I need some time.

• I need to see how my unpatched motors/hubs react and [ ] maybe even update my motor/hub.
• The XLarge motors are basically twins to the Large ones so I expect the same behavior there.
• I have to check whether the old hub has a software version different from yours, which would allow us to hold two different static port infos.

Give me a day or two

[tthiery]

So I re-run discovery on my xlarge and linear motors. Unfortunately, both are still reporting as 0.0.0.1000. So the new (yours) and old (mine) output is not distinguishable.

[tthiery]

So the change in your PR is compatible with the unpatched motor (which is good, then we can merge it without harm).

The hex-code contain two details

• The self-description raw range is changed from -360 to +360 to -179 to +180 which reflects also the real values we get (so they fixed the description to the actual behavior).
• The removed the "CALIB" mode ... which is probably a calibration mode during production or development of the motors (something like a final qualification test for the motors)

[tthiery]

I was able to use the Technical Control+ App to trigger a firmware update on my technic hub. Which allowed me to add the XLarge motor as well.

[tthiery]

Had to fix the Robot Inventor TechnicMediumAngularMotorGrey as well (tons of updates there). The sensors (distance and color) still worked. Unfortunately, this leaves TechnicLargeAngularMotorGrey hanging in the air (I do not have this one).

@rickjansen-dev I think you originally contributed this motor any chance you can update your firmware (e.g. via Technic Control+ app) and provide us updated hex-dumps and pretty prints?

[tthiery]

@mennolodder Thanks for your work and patience here. I was a bit under stress work-wise and unfortunately could not have a look earlier.

Unfortunately, the change was indeed a bit worse than expected. But I think both your fixes, the discovery disablement and this one will improve this product a lot. I would love to give @rickjansen-dev some days to respond. My goal is that at the end of the week to release v5.0.

[mennolodder]

Sweet, no problem. Glad I could help