Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

comment out :type of buffer slot in xtream defstruct on ABCL #2

Closed

Conversation

slyrus
Copy link
Member

@slyrus slyrus commented Aug 13, 2018

  • On ABCL, this triggers a sturcture redefinition error. A ticket has
    been filed on this (https://abcl.org/trac/ticket/450) but there has
    been no action on the ticket for at least 14 months. Copying out
    the type of the slot, at least for the moment, allows
    closure-common (and cxml) to be used on current ABCLs.

 * On ABCL, this triggers a sturcture redefinition error. A ticket has
   been filed on this (https://abcl.org/trac/ticket/450) but there has
   been no action on the ticket for at least 14 months. Copying out
   the type of the slot, at least for the moment, allows
   closure-common (and cxml) to be used on current ABCLs.
Copy link
Member

@scymtym scymtym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Two small typos in the commit message:

  1. "sturcture"
  2. "Copying out" should probably be "Commenting out"

@slyrus slyrus closed this Aug 13, 2018
@slyrus slyrus deleted the abcl-xstream-defstruct-type-hack branch August 13, 2018 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants