Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update inspect.lisp for more SBCL internal changes #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lispnik
Copy link

@lispnik lispnik commented Jul 24, 2021

This fixes #3 I pulled the code from SBCL's included sb-aclrepl which still shares a close lineage.

$ sbcl
This is SBCL 2.1.6, an implementation of ANSI Common Lisp.
More information about SBCL is available at <http://www.sbcl.org/>.

SBCL is free software, provided as is, with absolutely no warranty.
It is mostly in the public domain; some portions are provided under
BSD-style licenses.  See the CREDITS and COPYING files in the
distribution for more information.
* (ql:quickload "prepl")
To load "prepl":
  Load 1 ASDF system:
    prepl
; Loading "prepl"

("prepl")
* (prepl:repl)
Portable REPL on SBCL, main thread.  Type :help for help.
CL-USER> (defstruct foo x y)
FOO
CL-USER> :in (make-foo :x 123 :y 456)

#<STRUCTURE-CLASS COMMON-LISP-USER::FOO> at #x0000001001B41EA0
   0 X --------------> fixnum 123
   1 Y --------------> fixnum 456
[1i] CL-USER> 

@luismbo
Copy link
Member

luismbo commented Jul 24, 2021

Do you think it would be worthwhile to support older SBCL versions with conditionals?

@lispnik
Copy link
Author

lispnik commented Jul 26, 2021

@luismbo I don't know. I'll look into if it it's a thing, though. What are your thoughts?

@luismbo
Copy link
Member

luismbo commented Jul 28, 2021

@lispnik SLIME's SBCL backend typically does things like this: https://github.com/slime/slime/blob/68f5623f13c9a0d3d47ce70cf56928e00483d9d6/swank/sbcl.lisp#L459 If you have the time and inclination, it might be nice to do something similar here. If not, I'm happy to merge this pull request as is.

@xach
Copy link
Member

xach commented Sep 23, 2021

Any update on this? It would be nice to support old and new together if possible.

@lispnik
Copy link
Author

lispnik commented Sep 24, 2021

Thanks for the reminder, I’ll try get it to work for older SBCL releases.

jjkola pushed a commit to jjkola/prepl that referenced this pull request Jul 10, 2022
Based on comments on sharplispers#4
added with-symbol function to check the support for the new api.

with-symbol implementation copied from swank-backend.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

; Symbol "LAYOUT-INFO" not found in the SB-KERNEL package.
3 participants