feat: ✨ add choice of position for the sidebar #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a nice addition @philippart-s. I'm not quite sure if this is backwards compatible. What would happen if someone has not set sidebar:
position: left |
| @@ -4,5 +4,15 @@ | |||
|
|
|||
| @charset "utf-8"; | |||
|
|
|||
|
|
|||
| // define variable with front matter | |||
| {% if site.data.data.sidebar.position == 'left' %} | |||
There was a problem hiding this comment.
@sharu725 I think in the case sidebar.position is not defined, this would be false, and the sidebar is going to be on the right side 🤔
There was a problem hiding this comment.
I agree with you, I will test ASAP to be sure ;)
There was a problem hiding this comment.
That's right @nelsonmestevao. Let me test on my site as well.
Hi @sharu725, I've tested and if the option is not set then the sidebar is displayed to the right 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposition to enable the choice of the position of the sidebar : left or right 😉