Issue checkstyle#10649: Migrate to Inline Config Parser in SuppressWa…

…rningsCheckTest
shashwatj07 · Aug 20, 2021 · c61f91e · c61f91e
1 parent c9826c1
commit c61f91e
Show file tree

Hide file tree

Showing 34 changed files with 207 additions and 184 deletions.
diff --git a/pom.xml b/pom.xml
@@ -1781,7 +1781,6 @@
 
                 <exclude>**/InnerTypeLastCheckTest.class</exclude>
 
-                <exclude>**/SuppressWarningsCheckTest.class</exclude>
 
                 <exclude>**/ParenPadCheckTest.class</exclude>
 

diff --git a/...est/java/com/puppycrawl/tools/checkstyle/checks/annotation/SuppressWarningsCheckTest.java b/...est/java/com/puppycrawl/tools/checkstyle/checks/annotation/SuppressWarningsCheckTest.java
diff --git a/...eckstyle/checks/annotation/suppresswarnings/InputSuppressWarningsCompactNonConstant1.java b/...eckstyle/checks/annotation/suppresswarnings/InputSuppressWarningsCompactNonConstant1.java
@@ -71,7 +71,7 @@ void doFoo(String s, @SuppressWarnings({"unchecked"})String y) {
         }
     }
 
-    @SuppressWarnings({(false) ? "unchecked" : "", (false) ? "unchecked" : ""}) // violation
+    @SuppressWarnings({(false) ? "unchecked" : "", (false) ? "unchecked" : ""}) // 2 violations
     class Cond {
 
         @SuppressWarnings({(false) ? "" : "unchecked"}) // violation
@@ -91,7 +91,7 @@ public void aCond2() {
         }
 
         @java.lang.SuppressWarnings({(false) ? "unchecked" :
-                ("" == "") ? (false) ? (true) ? "" : "foo" : "   " : "unused", // violation
+                ("" == "") ? (false) ? (true) ? "" : "foo" : "   " : "unused", // 2 violations
             (false) ? "unchecked" : ("" == "") ? (false) ? (true) ? "" : // violation
                     "foo" : "   " : // violation
                     "unused"})

diff --git a/...eckstyle/checks/annotation/suppresswarnings/InputSuppressWarningsCompactNonConstant2.java b/...eckstyle/checks/annotation/suppresswarnings/InputSuppressWarningsCompactNonConstant2.java
@@ -12,13 +12,13 @@
 package com.puppycrawl.tools.checkstyle.checks.annotation.suppresswarnings;
 import java.lang.annotation.Documented;
 
-@SuppressWarnings({"unchecked", "unused"}) // violation
+@SuppressWarnings({"unchecked", "unused"}) // 2 violations
 public class InputSuppressWarningsCompactNonConstant2
 {
     @SuppressWarnings({"   "}) // violation
     class Empty {
 
-        @SuppressWarnings({"unchecked", ""}) // violation
+        @SuppressWarnings({"unchecked", ""}) // 2 violations
         public Empty() {
 
         }
@@ -27,7 +27,7 @@ public Empty() {
     @SuppressWarnings({"unused"}) // violation
     enum Duh {
 
-        @SuppressWarnings({"unforgiven", "    un"}) // violation
+        @SuppressWarnings({"unforgiven", "    un"}) // 2 violations
         D;
 
         public static void foo() {
@@ -54,7 +54,7 @@ public String toString() {
     @SuppressWarnings({}) // violation
     @interface MoreSweetness {
 
-        @SuppressWarnings({"unused", "bleh"}) // violation
+        @SuppressWarnings({"unused", "bleh"}) // 2 violations
         int cool();
     }
 
@@ -71,29 +71,29 @@ void doFoo(String s, @SuppressWarnings({"unchecked"})String y) { // violation
         }
     }
 
-    @SuppressWarnings({(false) ? "unchecked" : "", (false) ? "unchecked" : ""}) // violation
+    @SuppressWarnings({(false) ? "unchecked" : "", (false) ? "unchecked" : ""}) // 4 violations
     class Cond {
 
-        @SuppressWarnings({(false) ? "" : "unchecked"}) // violation
+        @SuppressWarnings({(false) ? "" : "unchecked"}) // 2 violations
         public Cond() {
 
         }
 
-        @SuppressWarnings({(false) ? (true) ? "   " : "unused" : "unchecked", // violation
-            (false) ? (true) ? "   " : "unused" : "unchecked"}) // violation
+        @SuppressWarnings({(false) ? (true) ? "   " : "unused" : "unchecked", // 3 violations
+            (false) ? (true) ? "   " : "unused" : "unchecked"}) // 3 violations
         public void aCond1() {
 
         }
 
-        @SuppressWarnings({(false) ? "unchecked" : (true) ? "   " : "unused"}) // violation
+        @SuppressWarnings({(false) ? "unchecked" : (true) ? "   " : "unused"}) // 3 violations
         public void aCond2() {
 
         }
 
         @java.lang.SuppressWarnings({(false) ? "unchecked" : // violation
-                ("" == "") ? (false) ? (true) ? "" : "foo" : "   " : "unused", // violation
-            (false) ? "unchecked" : ("" == "") ? (false) ? (true) ? "" : // violation
-                    "foo" : "   " : // violation
+                ("" == "") ? (false) ? (true) ? "" : "foo" : "   " : "unused", // 4 violations
+            (false) ? "unchecked" : ("" == "") ? (false) ? (true) ? "" : // 2 violations
+                    "foo" : "   " : // 2 violations
                     "unused"}) // violation
         public void seriously() {
 

diff --git a/...eckstyle/checks/annotation/suppresswarnings/InputSuppressWarningsCompactNonConstant3.java b/...eckstyle/checks/annotation/suppresswarnings/InputSuppressWarningsCompactNonConstant3.java
@@ -69,7 +69,7 @@ void doFoo(String s, @SuppressWarnings({"unchecked"})String y) {
         }
     }
 
-    @SuppressWarnings({(false) ? "unchecked" : "", (false) ? "unchecked" : ""}) // violation
+    @SuppressWarnings({(false) ? "unchecked" : "", (false) ? "unchecked" : ""}) // 2 violations
     class Cond {
 
         @SuppressWarnings({(false) ? "" : "unchecked"})

diff --git a/...eckstyle/checks/annotation/suppresswarnings/InputSuppressWarningsCompactNonConstant4.java b/...eckstyle/checks/annotation/suppresswarnings/InputSuppressWarningsCompactNonConstant4.java
@@ -12,7 +12,7 @@
 package com.puppycrawl.tools.checkstyle.checks.annotation.suppresswarnings;
 import java.lang.annotation.Documented;
 
-@SuppressWarnings({"unchecked", "unused"}) // violation
+@SuppressWarnings({"unchecked", "unused"}) // 2 violations
 public class InputSuppressWarningsCompactNonConstant4
 {
     @SuppressWarnings({"   "})
@@ -71,21 +71,21 @@ void doFoo(String s, @SuppressWarnings({"unchecked"})String y) { // violation
         }
     }
 
-    @SuppressWarnings({(false) ? "unchecked" : "", (false) ? "unchecked" : ""}) // violation
+    @SuppressWarnings({(false) ? "unchecked" : "", (false) ? "unchecked" : ""}) // 2 violations
     class Cond {
 
         @SuppressWarnings({(false) ? "" : "unchecked"}) // violation
         public Cond() {
 
         }
 
-        @SuppressWarnings({(false) ? (true) ? "   " : "unused" : "unchecked", // violation
-            (false) ? (true) ? "   " : "unused" : "unchecked"}) // violation
+        @SuppressWarnings({(false) ? (true) ? "   " : "unused" : "unchecked", // 2 violations
+            (false) ? (true) ? "   " : "unused" : "unchecked"}) // 2 violations
         public void aCond1() {
 
         }
 
-        @SuppressWarnings({(false) ? "unchecked" : (true) ? "   " : "unused"}) // violation
+        @SuppressWarnings({(false) ? "unchecked" : (true) ? "   " : "unused"}) // 2 violations
         public void aCond2() {
 
         }

diff --git a/...eckstyle/checks/annotation/suppresswarnings/InputSuppressWarningsCompactNonConstant5.java b/...eckstyle/checks/annotation/suppresswarnings/InputSuppressWarningsCompactNonConstant5.java
@@ -12,7 +12,7 @@
 package com.puppycrawl.tools.checkstyle.checks.annotation.suppresswarnings;
 import java.lang.annotation.Documented;
 
-@SuppressWarnings({"unchecked", "unused"}) // violation
+@SuppressWarnings({"unchecked", "unused"}) // 2 violations
 public class InputSuppressWarningsCompactNonConstant5
 {
     @SuppressWarnings({"   "})
@@ -71,29 +71,29 @@ void doFoo(String s, @SuppressWarnings({"unchecked"})String y) { // violation
         }
     }
 
-    @SuppressWarnings({(false) ? "unchecked" : "", (false) ? "unchecked" : ""}) // violation
+    @SuppressWarnings({(false) ? "unchecked" : "", (false) ? "unchecked" : ""}) // 2 violations
     class Cond {
 
         @SuppressWarnings({(false) ? "" : "unchecked"}) // violation
         public Cond() {
 
         }
 
-        @SuppressWarnings({(false) ? (true) ? "   " : "unused" : "unchecked", // violation
-            (false) ? (true) ? "   " : "unused" : "unchecked"}) // violation
+        @SuppressWarnings({(false) ? (true) ? "   " : "unused" : "unchecked", // 2 violations
+            (false) ? (true) ? "   " : "unused" : "unchecked"}) // 2 violations
         public void aCond1() {
 
         }
 
-        @SuppressWarnings({(false) ? "unchecked" : (true) ? "   " : "unused"}) // violation
+        @SuppressWarnings({(false) ? "unchecked" : (true) ? "   " : "unused"}) // 2 violations
         public void aCond2() {
 
         }
 
         @java.lang.SuppressWarnings({(false) ? "unchecked" : // violation
                 ("" == "") ? (false) ? (true) ? "" : "foo" : "   " : "unused", // violation
-            (false) ? "unchecked" : ("" == "") ? (false) ? (true) ? "" :
-                    "foo" : "   " : // violation
+            (false) ? "unchecked" : ("" == "") ? (false) ? (true) ? "" : // violation
+                    "foo" : "   " :
                     "unused"}) // violation
         public void seriously() {
 

diff --git a/...eckstyle/checks/annotation/suppresswarnings/InputSuppressWarningsCompactNonConstant6.java b/...eckstyle/checks/annotation/suppresswarnings/InputSuppressWarningsCompactNonConstant6.java
@@ -12,13 +12,13 @@
 package com.puppycrawl.tools.checkstyle.checks.annotation.suppresswarnings;
 import java.lang.annotation.Documented;
 
-@SuppressWarnings({"unchecked", "unused"}) // violation
+@SuppressWarnings({"unchecked", "unused"}) // 2 violations
 public class InputSuppressWarningsCompactNonConstant6
 {
     @SuppressWarnings({"   "}) // violation
     class Empty {
 
-        @SuppressWarnings({"unchecked", ""}) // violation
+        @SuppressWarnings({"unchecked", ""}) // 2 violations
         public Empty() {
 
         }
@@ -27,7 +27,7 @@ public Empty() {
     @SuppressWarnings({"unused"}) // violation
     enum Duh {
 
-        @SuppressWarnings({"unforgiven", "    un"}) // violation
+        @SuppressWarnings({"unforgiven", "    un"}) // 2 violations
         D;
 
         public static void foo() {
@@ -54,7 +54,7 @@ public String toString() {
     @SuppressWarnings({}) // violation
     @interface MoreSweetness {
 
-        @SuppressWarnings({"unused", "bleh"}) // violation
+        @SuppressWarnings({"unused", "bleh"}) // 2 violations
         int cool();
     }
 
@@ -71,29 +71,29 @@ void doFoo(String s, @SuppressWarnings({"unchecked"})String y) { // violation
         }
     }
 
-    @SuppressWarnings({(false) ? "unchecked" : "", (false) ? "unchecked" : ""}) // violation
+    @SuppressWarnings({(false) ? "unchecked" : "", (false) ? "unchecked" : ""}) // 4 violations
     class Cond {
 
-        @SuppressWarnings({(false) ? "" : "unchecked"}) // violation
+        @SuppressWarnings({(false) ? "" : "unchecked"}) // 2 violations
         public Cond() {
 
         }
 
-        @SuppressWarnings({(false) ? (true) ? "   " : "unused" : "unchecked", // violation
-            (false) ? (true) ? "   " : "unused" : "unchecked"}) // violation
+        @SuppressWarnings({(false) ? (true) ? "   " : "unused" : "unchecked", // 3 violations
+            (false) ? (true) ? "   " : "unused" : "unchecked"}) // 3 violations
         public void aCond1() {
 
         }
 
-        @SuppressWarnings({(false) ? "unchecked" : (true) ? "   " : "unused"}) // violation
+        @SuppressWarnings({(false) ? "unchecked" : (true) ? "   " : "unused"}) // 3 violations
         public void aCond2() {
 
         }
 
         @java.lang.SuppressWarnings({(false) ? "unchecked" : // violation
-                ("" == "") ? (false) ? (true) ? "" : "foo" : "   " : "unused", // violation
-            (false) ? "unchecked" : ("" == "") ? (false) ? (true) ? "" : // violation
-                    "foo" : "   " : // violation
+                ("" == "") ? (false) ? (true) ? "" : "foo" : "   " : "unused", // 4 violations
+            (false) ? "unchecked" : ("" == "") ? (false) ? (true) ? "" : // 2 violations
+                    "foo" : "   " : // 2 violations
                     "unused"}) // violation
         public void seriously() {
 

diff --git a/...ckstyle/checks/annotation/suppresswarnings/InputSuppressWarningsExpandedNonConstant1.java b/...ckstyle/checks/annotation/suppresswarnings/InputSuppressWarningsExpandedNonConstant1.java
@@ -71,7 +71,7 @@ void doFoo(String s, @SuppressWarnings(value={"unchecked"})String y) {
         }
     }
 
-    @SuppressWarnings(value={(false) ? "unchecked" : "", (false) ? "unchecked" : ""}) // violation
+    @SuppressWarnings(value={(false) ? "unchecked" : "", (false) ? "unchecked" : ""}) // 2 violations
     class Cond {
 
         @SuppressWarnings(value={(false) ? "" : "unchecked"}) // violation
@@ -91,9 +91,9 @@ public void aCond2() {
         }
 
         @java.lang.SuppressWarnings(value={(false) ? "unchecked" :
-                    ("" == "") ? (false) ? (true) ? "" : "foo" : "   " : "unused", // violation
+                    ("" == "") ? (false) ? (true) ? "" : "foo" : "   " : "unused", // 2 violations
                 (false) ? "unchecked" :
-                    ("" == "") ? (false) ? (true) ? "" : "foo" : "   " : "unused"}) // violation
+                    ("" == "") ? (false) ? (true) ? "" : "foo" : "   " : "unused"}) // 2 violations
         public void seriously() {
 
         }

diff --git a/...ckstyle/checks/annotation/suppresswarnings/InputSuppressWarningsExpandedNonConstant2.java b/...ckstyle/checks/annotation/suppresswarnings/InputSuppressWarningsExpandedNonConstant2.java
@@ -12,13 +12,13 @@
 package com.puppycrawl.tools.checkstyle.checks.annotation.suppresswarnings;
 import java.lang.annotation.Documented;
 
-@SuppressWarnings(value={"unchecked", "unused"}) // violation
+@SuppressWarnings(value={"unchecked", "unused"}) // 2 violations
 public class InputSuppressWarningsExpandedNonConstant2
 {
     @SuppressWarnings(value={"   "}) // violation
     class Empty {
 
-        @SuppressWarnings(value={"unchecked", ""}) // violation
+        @SuppressWarnings(value={"unchecked", ""}) // 2 violations
         public Empty() {
 
         }
@@ -27,7 +27,7 @@ public Empty() {
     @SuppressWarnings(value={"unused"}) // violation
     enum Duh {
 
-        @SuppressWarnings(value={"unforgiven", "    un"}) // violation
+        @SuppressWarnings(value={"unforgiven", "    un"}) // 2 violations
         D;
 
         public static void foo() {
@@ -54,7 +54,7 @@ public String toString() {
     @SuppressWarnings(value={}) // violation
     @interface MoreSweetness {
 
-        @SuppressWarnings(value={"unused", "bleh"}) // violation
+        @SuppressWarnings(value={"unused", "bleh"}) // 2 violations
         int cool();
     }
 
@@ -71,29 +71,29 @@ void doFoo(String s, @SuppressWarnings(value={"unchecked"})String y) { // violat
         }
     }
 
-    @SuppressWarnings(value={(false) ? "unchecked" : "", (false) ? "unchecked" : ""}) // violation
+    @SuppressWarnings(value={(false) ? "unchecked" : "", (false) ? "unchecked" : ""}) // 4 violations
     class Cond {
 
-        @SuppressWarnings(value={(false) ? "" : "unchecked"}) // violation
+        @SuppressWarnings(value={(false) ? "" : "unchecked"}) // 2 violations
         public Cond() {
 
         }
 
-        @SuppressWarnings(value={(false) ? (true) ? "   " : "unused" : "unchecked", // violation
-            (false) ? (true) ? "   " : "unused" : "unchecked"}) // violation
+        @SuppressWarnings(value={(false) ? (true) ? "   " : "unused" : "unchecked", // 3 violations
+            (false) ? (true) ? "   " : "unused" : "unchecked"}) // 3 violations
         public void aCond1() {
 
         }
 
-        @SuppressWarnings(value={(false) ? "unchecked" : (true) ? "   " : "unused"}) // violation
+        @SuppressWarnings(value={(false) ? "unchecked" : (true) ? "   " : "unused"}) // 3 violations
         public void aCond2() {
 
         }
 
         @java.lang.SuppressWarnings(value={(false) ? "unchecked" : // violation
-                    ("" == "") ? (false) ? (true) ? "" : "foo" : "   " : "unused", // violation
+                    ("" == "") ? (false) ? (true) ? "" : "foo" : "   " : "unused", // 4 violations
                 (false) ? "unchecked" : // violation
-                    ("" == "") ? (false) ? (true) ? "" : "foo" : "   " : "unused"}) // violation
+                    ("" == "") ? (false) ? (true) ? "" : "foo" : "   " : "unused"}) // 4 violations
         public void seriously() {
 
         }

diff --git a/...ckstyle/checks/annotation/suppresswarnings/InputSuppressWarningsExpandedNonConstant3.java b/...ckstyle/checks/annotation/suppresswarnings/InputSuppressWarningsExpandedNonConstant3.java
@@ -71,7 +71,7 @@ void doFoo(String s, @SuppressWarnings(value={"unchecked"})String y) { // violat
         }
     }
 
-    @SuppressWarnings(value={(false) ? "unchecked" : "", (false) ? "unchecked" : ""}) // violation
+    @SuppressWarnings(value={(false) ? "unchecked" : "", (false) ? "unchecked" : ""}) // 2 violations
     class Cond {
 
         @SuppressWarnings(value={(false) ? "" : "unchecked"}) // violation

diff --git a/...ckstyle/checks/annotation/suppresswarnings/InputSuppressWarningsExpandedNonConstant4.java b/...ckstyle/checks/annotation/suppresswarnings/InputSuppressWarningsExpandedNonConstant4.java
@@ -69,7 +69,7 @@ void doFoo(String s, @SuppressWarnings(value={"unchecked"})String y) {
         }
     }
 
-    @SuppressWarnings(value={(false) ? "unchecked" : "", (false) ? "unchecked" : ""}) // violation
+    @SuppressWarnings(value={(false) ? "unchecked" : "", (false) ? "unchecked" : ""}) // 2 violations
     class Cond {
 
         @SuppressWarnings(value={(false) ? "" : "unchecked"})