Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract OpenHatch-specific details in a configuration file #46

Open
jdm opened this issue Nov 18, 2014 · 4 comments
Open

Extract OpenHatch-specific details in a configuration file #46

jdm opened this issue Nov 18, 2014 · 4 comments

Comments

@jdm
Copy link

jdm commented Nov 18, 2014

There are lots of Python constants that could be moved into a configuration file instead of being hardcoded. This would make configuring a non-OpenHatch bot easier, and allow staying up to date with changes to WelcomeBot without having to merge.

@shaunagm
Copy link
Owner

This is an excellent point. We already have to do a bit of set-up to avoid this issue with the generated nickname file, so we can easily accommodate setting up a separate config file. Labelling and accepting this. Do you want to work on this yourself?

@jdm
Copy link
Author

jdm commented Nov 18, 2014

I'm considering it, since I'd like to run a bot for Servo's IRC channel. I'll leave a note here if I start working on it.

@aaparella
Copy link
Contributor

Began work on this (PR #49). Open for critique :)

@pdurbin
Copy link

pdurbin commented Nov 26, 2014

As I mentioned in IRC to @shaunagm I'm expecially interested in being able to configure the welcome message in a config file.

@aaparella I don't see that at https://github.com/aaparella/WelcomeBot/blob/configparser/settings.ini from a quick look. Would you be able to add the ability to put the welcome message in the config file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants