Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nicks with underscores are recorded incorrectly #62

Open
mapkyca opened this issue May 26, 2016 · 1 comment
Open

Nicks with underscores are recorded incorrectly #62

mapkyca opened this issue May 26, 2016 · 1 comment

Comments

@mapkyca
Copy link

mapkyca commented May 26, 2016

e.g _foo_ is saved as foo

@SwartzCr
Copy link

SwartzCr commented Feb 9, 2017

this is intentional to work around the case where someone who is having connectivity issues with their server (or hasn't yet authenticated their nick) gets underscores appended to their name.
The code for it is here: https://github.com/shaunagm/WelcomeBot/blob/master/bot.py#L132
though in theory that line should use rstrip instead of replace
So while the nicks.csv will be 'wrong' it shouldn't confuse that user for another one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants