Handle arrays, other improvements #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents pulling in all of util module source for bundled builds (e.g., when using webpack).
For example, if the key is "auth-token" and one of the keywords is "token", then the "auth-token" key will be redacted.
Running redact on a non-plain object (an object with a prototype, e.g., an instance of http.IncomingMessage) may result in unexpected behavior due to the prototype chain and non-enumerable properties.
|
I like it. The only issue I have is that it doesn't do partial matching and you are adding that. To make it backwards compatible, I would want to put that feature behind a flag. I will merge this then add the flag. Thanks for your contribution! |
|
Pushed these changes to NPM as 2.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements various changes I needed for my use case. Notably:
"AUTH-TOKEN"is the key, and one of the keywords is"token", then the"AUTH-TOKEN"key will be redacted