track "/me" IRC actions #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Twisted tracks normal IRC messages using the privmsg() method and "/me" IRC messages using the action() method. Alias the action method to the privmsg method so that Helga will process both types of messages. This change allows plugins to trigger on content in "/me" IRC messages.
|
Thank you for this! I think this will help me out quite a bit for #128. If it's alright, I'd like to experiment a bit with this to see some of the behavior with respect to the channel logger. I think it'll probably be fine, but I just wanted to make sure. |
|
Hi Shaun, @zmc and I were discussing this again today. Does it look ok to merge? |
|
Oh my gosh, I'm so sorry this went stale for a while. It all looks good to me. I'll see about getting a new release out tomorrow. |
|
Just released helga 1.7.2 to include this change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Twisted tracks normal IRC messages using the privmsg() method and "/me" IRC messages using the action() method.
This pull request aliases the action method to the privmsg method so that Helga will process both types of messages. This change allows plugins to trigger on content in "/me" IRC messages.