Uses 'self' instead of 'window' global variable (#42) #43

yveslange · 2017-09-13T12:41:33Z

window global variable might be define in node (eg: Jest defines it).

It is safer to use self to test if the library is running in the browser environnement or under nodejs.

This is not the perfect answer to resolve the problem but at least, the library will work when using Jest or other libs that defines window in nodejs.

coveralls · 2017-09-13T12:45:51Z

Coverage remained the same at 92.241% when pulling b35aaee on yveslange:master into 9e2a9bd on shaunxcode:master.

yveslange · 2017-09-13T12:57:19Z

There is a mistake in this PR

Uses 'self' instead of 'window' global variable (#42)

b35aaee

yveslange closed this Sep 13, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uses 'self' instead of 'window' global variable (#42) #43

Uses 'self' instead of 'window' global variable (#42) #43

yveslange commented Sep 13, 2017

coveralls commented Sep 13, 2017 •

edited

yveslange commented Sep 13, 2017

Uses 'self' instead of 'window' global variable (#42) #43

Uses 'self' instead of 'window' global variable (#42) #43

Conversation

yveslange commented Sep 13, 2017

coveralls commented Sep 13, 2017 • edited

yveslange commented Sep 13, 2017

coveralls commented Sep 13, 2017 •

edited