Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent infinite dmp recursion #49

Merged
merged 1 commit into from
May 1, 2023

Conversation

sander2
Copy link
Contributor

@sander2 sander2 commented Apr 27, 2023

Without this fix, I got a stackoverflow when trying to send this message from the relay chain to the parachain:

[
        ReserveAssetDeposited((Parent, 1000000000000u128).into()),
        BuyExecution {
            fees: (Parent, 100000000000u128).into(),
            weight_limit: Unlimited,
        },
        QueryPallet {
            module_name: "frame_system".into(), response_info: QueryResponseInfo {
                destination: Parent.into(),
                query_id: 1,
                max_weight:Weight::from_ref_time(10000000000000000u64)
            }
        }
]

The stacktrace that I got was (slightly abbreviated):

kusama_test_net::_process_downward_messages (xcm-simulator-ce151af85e435b6b/754f3b9/xcm-emulator/src/lib.rs:361)
kusama_test_net::_process_messages (xcm-simulator-ce151af85e435b6b/754f3b9/xcm-emulator/src/lib.rs:332)
<kusama_test_net::KusamaNet as xcm_emulator::TestExt>::execute_with (xcm-simulator-ce151af85e435b6b/754f3b9/xcm-emulator/src/lib.rs:157)
<kusama_test_net::KusamaNet as polkadot_runtime_parachains::ump::UmpSink>::process_upward_message (xcm-simulator-ce151af85e435b6b/754f3b9/xcm-emulator/src/lib.rs:59)
kusama_test_net::_process_upward_messages (xcm-simulator-ce151af85e435b6b/754f3b9/xcm-emulator/src/lib.rs:393)
kusama_test_net::_process_messages (xcm-simulator-ce151af85e435b6b/754f3b9/xcm-emulator/src/lib.rs:330)
<kusama_test_net::Kintsugi as xcm_emulator::TestExt>::execute_with (xcm-simulator-ce151af85e435b6b/754f3b9/xcm-emulator/src/lib.rs:273)
<kusama_test_net::Kintsugi as polkadot_parachain::primitives::DmpMessageHandler>::handle_dmp_messages (xcm-simulator-ce151af85e435b6b/754f3b9/xcm-emulator/src/lib.rs:102)

kusama_test_net::_process_downward_messages (xcm-simulator-ce151af85e435b6b/754f3b9/xcm-emulator/src/lib.rs:361)
kusama_test_net::_process_messages (xcm-simulator-ce151af85e435b6b/754f3b9/xcm-emulator/src/lib.rs:332)
<kusama_test_net::KusamaNet as xcm_emulator::TestExt>::execute_with (xcm-simulator-ce151af85e435b6b/754f3b9/xcm-emulator/src/lib.rs:157)
<kusama_test_net::KusamaNet as polkadot_runtime_parachains::ump::UmpSink>::process_upward_message (xcm-simulator-ce151af85e435b6b/754f3b9/xcm-emulator/src/lib.rs:59)
kusama_test_net::_process_upward_messages (xcm-simulator-ce151af85e435b6b/754f3b9/xcm-emulator/src/lib.rs:393)
kusama_test_net::_process_messages (xcm-simulator-ce151af85e435b6b/754f3b9/xcm-emulator/src/lib.rs:330)
<kusama_test_net::Kintsugi as xcm_emulator::TestExt>::execute_with (xcm-simulator-ce151af85e435b6b/754f3b9/xcm-emulator/src/lib.rs:273)
<kusama_test_net::Kintsugi as polkadot_parachain::primitives::DmpMessageHandler>::handle_dmp_messages (xcm-simulator-ce151af85e435b6b/754f3b9/xcm-emulator/src/lib.rs:102)

<repeat>

@shaunxw shaunxw merged commit ddf0c0d into shaunxw:master May 1, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants