Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More additions and fixes #364

Merged
merged 6 commits into from Jun 21, 2017
Merged

More additions and fixes #364

merged 6 commits into from Jun 21, 2017

Conversation

shavitush
Copy link
Owner

@shavitush shavitush commented Jun 17, 2017

  1. Modernized the sm_style menu so it's more spaced, shows your current style and disables the ability to select it.
  2. Fixed the chat/menu output issues (Chat output issue #358).
  3. Fixed issues with shavit-rankings.phrases.txt.
  4. Implemented the ability to save/load timer snapshots dynamically, this allows @nknm's idea of real-time checkpoints to become reality and makes the TAS concept much easier to do. I have implemented it so checkpoints (sm_cpmenu) will use the new snapshots, as requested in checkpoints #313.
  5. Added practice mode. To enable practice mode, teleport using the checkpoints menu. Practice mode is very similar to unranked mode - your times will not be saved!
  6. Added velocity as a style setting. (New 'velocity' style setting #363)

Things that I should probably do before merging this pull request:

  • Have someone with a CS:GO server make the practice mode part fit into the CS:GO HUD.
  • Have users test snapshots and try to find ways to exploit them.

@Technoblazed
Copy link
Contributor

Technoblazed commented Jun 19, 2017

@strafe
Copy link
Contributor

strafe commented Jun 19, 2017

I don't think that can be corrected with the timer, as far as I know game_text channels don't work properly in CS:GO and certain resolutions affect the text size.

Valve is keeping track of it here and it looks fine for me on 1920 x 1080.
image

@Technoblazed
Copy link
Contributor

Technoblazed commented Jun 19, 2017 via email

@Nickelony
Copy link
Collaborator

Nickelony commented Jun 19, 2017

@strafe Wait, that screenshot was taken on our speedrun server. Are you working for 3kliks or is this just a coincidence cuz this server is not fully public yet.

BTW the text won't disappear for some reason, idk if it's a config problem or something. (!hud doesn't work aswell)

@shavitush
Copy link
Owner Author

Works fine for me in-game on 1920x1080, just like @strafe has it. You can disable it from the sm_hud menu if it doesn't work properly, and hopefully Valve will fix it in-game soon. Might be an issue with 16:10 resolutions..?

However, any feedback about snapshots and practice mode?

@Nickelony anything in error logs? I haven't done any recent changes to the HUD command/menu so I don't think anything was supposed to break :(.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants