Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement chat handler #69

Merged
merged 19 commits into from
Jul 12, 2016
Merged

Implement chat handler #69

merged 19 commits into from
Jul 12, 2016

Conversation

shavitush
Copy link
Owner

@shavitush shavitush commented Jul 12, 2016

Chat (NEW!)

Requires Dynamic to compile and run.

  • Add logic that processes chat without requiring an external plugin such as Simple Chat Processor (Redux).
  • RTLer support.
  • Custom chat titles/colors per individual player.
  • Custom chat titles/colors for rank ranges.
  • Update cache for a player when his rank updates.
  • Add sm_ranks sm_chatranks.
  • Add Shavit_FormatChat native.

@shavitush shavitush added this to the 1.5b milestone Jul 12, 2016
@shavitush shavitush self-assigned this Jul 12, 2016
@shavitush
Copy link
Owner Author

Opinions before I merge to master?

@Technoblazed
Copy link
Contributor

Taking a minute to look through the code, two secs :D

@Technoblazed
Copy link
Contributor

Everything seems good, how difficult would a % based ranking system be to implement into this?

@shavitush
Copy link
Owner Author

Shouldn't be too hard (I think!), could you elaborate?

@Technoblazed
Copy link
Contributor

As it stands at the minute, this chat would do, i.e:

1 -> Master
2-5 -> Pro
7-15 -> Semipro Etc.

The percentage based system would be more along the lines of,

1 -> Master
Top 1% -> Pro
Top 2-5% -> Semipri etc.

Where the % is the top of all players that use the server.

@shavitush
Copy link
Owner Author

I see. I'll merge this for pull for now though. Would be cool if you started an issue asking for percentage-based rankings so it'll be easier to track. It will be probably a must for 1.5b.

@shavitush shavitush merged commit 0fac03e into master Jul 12, 2016
@shavitush shavitush deleted the chat branch July 12, 2016 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants