Skip to content

Commit

Permalink
Constrain supported versions to ^3.6.7
Browse files Browse the repository at this point in the history
  • Loading branch information
shawalli committed Jul 22, 2020
1 parent 760cc15 commit eebc37e
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 5 deletions.
10 changes: 8 additions & 2 deletions .github/workflows/pipeline.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,10 @@ jobs:

strategy:
matrix:
python-version: [3.4, 3.5, 3.6, 3.7, 3.8]
python-version:
- 3.6.7
- 3.7
- 3.8

runs-on: ubuntu-latest

Expand Down Expand Up @@ -63,7 +66,10 @@ jobs:

strategy:
matrix:
python-version: [3.4, 3.5, 3.6, 3.7, 3.8]
python-version:
- 3.6.7
- 3.7
- 3.8

runs-on: ubuntu-latest

Expand Down
11 changes: 11 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,17 @@ def pullrequest_handler(data):
print('Received the following PULL-REQUEST event:{}'.format(data))
```

## Versions
Version 0.1.x supports `^2.7` and `^3.4`.

Versions 0.2+ supports `^3.6.7`. This is primarily due to Python version
constraints on the package and test tools. For instance, here are some
dependencies and their supported Python versions: `poetry=^3.4`,
`coveralls=^3.5`, `pre-commit=^3.6.1`, and `pytest=^3.6`. Due to these
constraints, the decision was made to drop official support for `2.7`, `3.4`
and `3.5`. However, `flask-github-webhook=^0.1.x` should work for older
Python versions.

## Configuration
The extension has the same configurations available as the `python-github-webhook` package. However, unlike referenced package, this extension reads those configurations from the Flask application, not initialization arguments. The values below should be configured in the Flask application (app.config) prior to initializing the extension.

Expand Down
5 changes: 2 additions & 3 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ classifiers = [
"Intended Audience :: System Administrators",
"License :: OSI Approved :: MIT License",
"Operating System :: OS Independent",
"Programming Language :: Python :: 2",
"Programming Language :: Python :: 3",
"Topic :: Software Development :: Libraries :: Python Modules",
"Topic :: Software Development :: Version Control :: Git"
Expand All @@ -25,7 +24,7 @@ include = [
]

[tool.poetry.dependencies]
python = "^3.4"
python = "^3.6.7"
github-webhook = "^1.0.2"

[tool.poetry.dev-dependencies]
Expand All @@ -36,7 +35,7 @@ pytest-cov = "^2.10.0"

[tool.black]
line-length = 120
target-version = ["py37", "py38"]
target-version = ["py36", "py37", "py38"]
include = "\\.pyi?$"
exclude = """
/(
Expand Down

0 comments on commit eebc37e

Please sign in to comment.