Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: added connection leakage test for OkHttp #10

Merged
merged 1 commit into from
Dec 13, 2022
Merged

test: added connection leakage test for OkHttp #10

merged 1 commit into from
Dec 13, 2022

Conversation

manusa
Copy link

@manusa manusa commented Dec 13, 2022

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@manusa
test: added connection leakage test for OkHttp
82e98b3 
Signed-off-by: Marc Nuri <marc@marcnuri.com>
@shawkins shawkins merged commit 562dd65 into shawkins:okhttp_close Dec 13, 2022
@manusa manusa deleted the review_okhttp_close branch December 13, 2022 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@manusa @shawkins