Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic support for properties #83

Merged
merged 1 commit into from Jan 3, 2016

Conversation

marceldev89
Copy link
Contributor

Added basic support for properties that are added during runtime (e.g. CakePHP adds properties to controllers that reference models/helpers/etc). This was briefly talked about in #82 (comment) and I figured I'd give it a try.

This pull request is more about getting my changes reviewed than getting it merged. It's my first ever adventure in vim plugins/scripting so there's probably a lot that's not how it's supposed to be done. 馃槃

In, probably, a really hacky way...
@complex857
Copy link
Collaborator

@marceldev89 Thank you for spending the time and effort to write the code.
As you most certainly know, the main thing that needed to be done is to make the class-content-grabbing process return the docblock for the classes (the @property comments are usually resides outside of the class's code itself). Now that we got the class's docbock comment, we can try to add support for @method comments too.

I'll try to write a few test's for your code so we can be sure that it continues to work as intended.

It's my first ever adventure in vim plugins/scripting

Welcome to the herd (-:

@complex857 complex857 merged commit d19ce98 into shawncplus:master Jan 3, 2016
complex857 pushed a commit that referenced this pull request Jan 3, 2016
@complex857
Copy link
Collaborator

I've merged and pushed your code with one feature addition (made @property stuff show up in the class completions) and with tests so that they should be somewhat safe against regressions and have a baseline for later improvements.

Thank you again for the code, i really appreciate it and sorry for the delay.

@marceldev89
Copy link
Contributor Author

Awesome! 馃槃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants