Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Index is being passed incorrect min and max vals #14

Closed
shawnlaffan opened this issue Mar 4, 2014 · 0 comments
Closed

Index is being passed incorrect min and max vals #14

shawnlaffan opened this issue Mar 4, 2014 · 0 comments
Assignees
@shawnlaffan

Comments

@shawnlaffan
Copy link
Owner

G::S::Shape::build_spatial_index is passing the bounds in the wrong order. This makes the index incorrect.
shawnlaffan added a commit that referenced this issue Mar 4, 2014
@shawnlaffan
Use correct min and max values when getting the bounds.
3aa693a 
Add more test data and tests.
Updates #14
@shawnlaffan shawnlaffan self-assigned this Mar 5, 2014
jsonn pushed a commit to jsonn/pkgsrc that referenced this issue May 1, 2015
Update to 2.60
7ce7de4 
Update my mail

Upstream changes:
2.60 2014-03-14
    - Add method to obtain the dbf header information.
      shawnlaffan/Geo-ShapeFile#15
    - Clean up some POD formatting issues.

2.58 2014-03-06
    - CPAN testers are green for 2.57_001 so make a production release.
    - Fix incorrect passing of arguments in the shape index.
      This should not affect most existing code as the indexing
      is only used when called explicitly.
      shawnlaffan/Geo-ShapeFile#14
    - Croak when an invalid file name is passed.
      shawnlaffan/Geo-ShapeFile#13

2.57_001 2014-03-05
    Development release towards 2.58.  Changes are listed there.

2.56 2014-02-18
    - Shawn Laffan
    - CPAN testers are green for 2.55_001, so bump the version number and release as a full version.

2.55_001 2014-02-17
    - Shawn Laffan
    - Add Geo::ShapeFile::Shape::Index as a simple 2-d block based index.
    - Geo::Shape::ShapeFile now uses a spatial index for the segments.
      This speeds up the contains_point routines by about 50-70% when used.
      The index is opt-in at the moment, so will have no effect on existing code.
    - Geo::ShapeFile::get_part now returns an array ref in scalar context.
    - Geo::ShapeFile::Point::angle_to now works.
    - Many of the undocumented methods have been renamed to use a leading underscore,
      as they are private methods.  This avoids a number of POD test warnings.
    - Add parent, POSIX and autovovofication to the list of dependencies in the makefile.

2.54 2014-02-11
    - Shawn Laffan
    - Fix https://rt.cpan.org/Ticket/Display.html?id=89563
      Thanks to Daniel Smith for reporting, and also providing an optimisation
      which also handles edge overlap cases.
    - Reorganise the test suite to allow running of subsets of tests.

2.53_003 2014-02-10
    - Shawn Laffan
    - Clear up several longstanding RT tickets:
        - https://rt.cpan.org/Ticket/Display.html?id=46698
          Clarify docs such that point objects are passed to has_point, not coordinates.
        - https://rt.cpan.org/Ticket/Display.html?id=46068
          Values returned from width and height were swapped.  Thanks to Le Goddard for reporting.
        - https://rt.cpan.org/Ticket/Display.html?id=49054
          $@ should have been @_ (thanks to rgsave@hotmail.com for reporting)
        - https://rt.cpan.org/Ticket/Display.html?id=92790
          DBF field names can now be accessed in file order.
        - https://rt.cpan.org/Ticket/Display.html?id=63347
          corners were incorrectly reported.  Thanks to Liam Gretton for reporting.
    - Reorganise the test suite to use subtests, with tests in subs.  Add more tests.
    - General formatting and style changes to the code.
    - Add List::Util as a dependency.
    - Development is now on github, so update the metadata to reflect this.
      https://github.com/shawnlaffan/Geo-ShapeFile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shawnlaffan shawnlaffan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shawnlaffan