Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tree trimming - add default option to merge single child branches with their child #814

Closed
3 tasks done
shawnlaffan opened this issue Aug 12, 2022 · 1 comment
Closed
3 tasks done

Tree trimming - add default option to merge single child branches with their child #814

shawnlaffan opened this issue Aug 12, 2022 · 1 comment
Assignees
@shawnlaffan
Labels
trees
Milestone
Release_4.0

Comments

@shawnlaffan
Copy link
Owner

shawnlaffan commented Aug 12, 2022 •
edited

Often when trimming a tree the resultant tree can have "knuckle" nodes. These are where a branch will have only a single child subtending from it.

In many cases these should be merged to form a single branch.

This can be added as an option to the tree trimming process, and set as the default.

Tasks:
@shawnlaffan shawnlaffan added this to the Release_4.0 milestone Aug 12, 2022
@shawnlaffan shawnlaffan self-assigned this Aug 12, 2022
shawnlaffan added a commit that referenced this issue Sep 12, 2022
@shawnlaffan
Tees: Add method to merge knuckle nodes
2f99545 
Updates #814
shawnlaffan added a commit that referenced this issue Sep 12, 2022
@shawnlaffan
tree knuckle merger: Avoid extra sorting
366ee31 
Filter the list of nodes before we sort,
and use a cache to avoid method calls.

Updates #814
shawnlaffan added a commit that referenced this issue Sep 12, 2022
@shawnlaffan
GUI: Add option to remove knuckle nodes from trees when transforming
19d1ae1 
Updates #814
shawnlaffan added a commit that referenced this issue Sep 12, 2022
@shawnlaffan
Tree knuckles: Avoid quadratic time cache clearing
2baf4e8 
Updates #814
shawnlaffan added a commit that referenced this issue Sep 12, 2022
@shawnlaffan
GUI: Add menu option to merge tree knuckle nodes
aefb514 
Updates #814
shawnlaffan added a commit that referenced this issue Sep 12, 2022
@shawnlaffan
GUI: refactor repeated dialogue code
c5ef9c5 
And hide the knuckle merger menu item when
there is no selected tree.

Updates #814
shawnlaffan added a commit that referenced this issue Nov 25, 2022
@shawnlaffan
Clear node depths when merging knuckle nodes
4529b4d 
Updates #814
@shawnlaffan
Copy link
Owner Author

All tasks completed, closing issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shawnlaffan shawnlaffan

Labels
trees
Projects
None yet
Milestone
Release_4.0
Development

No branches or pull requests
1 participant
@shawnlaffan