Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spreadsheet imports: Add Excel::ValueReader::XLSX backend #882

Closed
shawnlaffan opened this issue Oct 22, 2023 · 0 comments · Fixed by #884
Closed

Spreadsheet imports: Add Excel::ValueReader::XLSX backend #882

shawnlaffan opened this issue Oct 22, 2023 · 0 comments · Fixed by #884
Assignees
@shawnlaffan
Labels
data import
Milestone
Release_5.0

Comments

@shawnlaffan
Copy link
Owner

Excel::ValueReader::XLSX is much faster than SpreadSheet::Read.

It only gets the values from the worksheets but that's all we need.
@shawnlaffan shawnlaffan added this to the Release_5.0 milestone Oct 22, 2023
@shawnlaffan shawnlaffan self-assigned this Oct 22, 2023
@shawnlaffan shawnlaffan changed the title Spreadsheet imports: Change the backend to Excel::ValueReader::XLSX Spreadsheet imports: Add Excel::ValueReader::XLSX backend Oct 22, 2023
shawnlaffan added a commit that referenced this issue Oct 22, 2023
@shawnlaffan
Parse XLSX files using Excel::ValueReader::XLSX
1ebf51c 
This is substantially faster than the one used in SpreadSheet::Read.

It only provides the cell values but that is all we need.

Updates #882
shawnlaffan added a commit that referenced this issue Oct 23, 2023
@shawnlaffan
Parse XLSX files using Excel::ValueReader::XLSX
b087cf0 
This is substantially faster than the one used in SpreadSheet::Read.

It only provides the cell values but that is all we need.

Updates #882
@shawnlaffan shawnlaffan mentioned this issue Oct 23, 2023
Merged
shawnlaffan added a commit that referenced this issue Oct 23, 2023
@shawnlaffan
Parse XLSX files using Excel::ValueReader::XLSX
4fc2303 
This is substantially faster than the one used in SpreadSheet::Read.

It only provides the cell values but that is all we need.

Updates #882
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shawnlaffan shawnlaffan

Labels
data import
Projects
None yet
Milestone
Release_5.0
Development

Successfully merging a pull request may close this issue.

Parse XLSX files using Excel::ValueReader::XLSX shawnlaffan/biodiverse
1 participant
@shawnlaffan