Skip to content
This repository has been archived by the owner on Jan 31, 2018. It is now read-only.

assuming presence of json gem is problematic #3

Closed
geemus opened this issue Jun 15, 2012 · 10 comments
Closed

assuming presence of json gem is problematic #3

geemus opened this issue Jun 15, 2012 · 10 comments

Comments

@geemus
Copy link

geemus commented Jun 15, 2012

See: https://github.com/heroku/manager-cli/blob/master/lib/heroku/command/manager.rb#L3

The heroku gem doesn't depend on json and plugins don't install gems so this can cause issues. Particularly it is problematic in the case of toolbelt stuff due to the way gems are handled there. It would be better to use the vendored json capabilities in heroku, which can be used via Heroku::OkJson.decode() and Heroku::OkJson.encode().

Hopefully thats clear and should be straightforward to change, but let me know if you have questions or need help. Thanks!

@shayfrendt
Copy link
Owner

Nice - thanks for the tip!

I won't be able to get a change out right away, but I also won't stand
in the way of pull requests. :-D

On Jun 15, 2012, at 17:34, Wesley Beary
reply@reply.github.com
wrote:

See: https://github.com/heroku/manager-cli/blob/master/lib/heroku/command/manager.rb#L3

The heroku gem doesn't depend on json and plugins don't install gems so this can cause issues. Particularly it is problematic in the case of toolbelt stuff due to the way gems are handled there. It would be better to use the vendored json capabilities in heroku, which can be used via Heroku::OkJson.decode() and Heroku::OkJson.encode().

Hopefully thats clear and should be straightforward to change, but let me know if you have questions or need help. Thanks!


Reply to this email directly or view it on GitHub:
#3

@geemus
Copy link
Author

geemus commented Jun 15, 2012

@shayfrendt - sure thing. I don't think there is any particular hurry, but it was causing segfaults for some people using toolbelt (I wasn't able to reproduce, but anyway) thought I would pass it along so you would be aware.

@RandomEtc
Copy link

I just ran into this issue - I'm using the downloadable Toolbelt and installing the json gem made no difference. No segfaults, but the ranger plugin wouldn't install.

@geemus
Copy link
Author

geemus commented Aug 2, 2012

@RandomEtc - using the gem should allow you to get around this until a fix is available.

@geemus
Copy link
Author

geemus commented Aug 2, 2012

@RandomEtc - more specifically, using the heroku gem (rather than toolbelt) should let you get around this.

@RandomEtc
Copy link

Unfortunately using the Heroku Toolbelt was the recommended solution for some other issues I had with the gem :) If I decide to look at this again I'll fork the plugin and fix it for the Toolbelt.

@geemus
Copy link
Author

geemus commented Aug 3, 2012

@RandomEtc - ah. got it. It should be a pretty straightforward fix, but let me know if you give it a shot and have trouble.

@m1foley
Copy link
Contributor

m1foley commented Aug 15, 2012

Here ya go: #5

@shayfrendt
Copy link
Owner

@m1foley Awesome - thanks sir. I'll try that out and get it merged down to master shortly.

@shayfrendt
Copy link
Owner

Aight this should be all working correctly now via #5.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants