-
Notifications
You must be signed in to change notification settings - Fork 4
assuming presence of json gem is problematic #3
Comments
Nice - thanks for the tip! I won't be able to get a change out right away, but I also won't stand On Jun 15, 2012, at 17:34, Wesley Beary
|
@shayfrendt - sure thing. I don't think there is any particular hurry, but it was causing segfaults for some people using toolbelt (I wasn't able to reproduce, but anyway) thought I would pass it along so you would be aware. |
I just ran into this issue - I'm using the downloadable Toolbelt and installing the json gem made no difference. No segfaults, but the ranger plugin wouldn't install. |
@RandomEtc - using the gem should allow you to get around this until a fix is available. |
@RandomEtc - more specifically, using the heroku gem (rather than toolbelt) should let you get around this. |
Unfortunately using the Heroku Toolbelt was the recommended solution for some other issues I had with the gem :) If I decide to look at this again I'll fork the plugin and fix it for the Toolbelt. |
@RandomEtc - ah. got it. It should be a pretty straightforward fix, but let me know if you give it a shot and have trouble. |
Here ya go: #5 |
@m1foley Awesome - thanks sir. I'll try that out and get it merged down to master shortly. |
Aight this should be all working correctly now via #5. |
See: https://github.com/heroku/manager-cli/blob/master/lib/heroku/command/manager.rb#L3
The heroku gem doesn't depend on json and plugins don't install gems so this can cause issues. Particularly it is problematic in the case of toolbelt stuff due to the way gems are handled there. It would be better to use the vendored json capabilities in heroku, which can be used via
Heroku::OkJson.decode()
andHeroku::OkJson.encode()
.Hopefully thats clear and should be straightforward to change, but let me know if you have questions or need help. Thanks!
The text was updated successfully, but these errors were encountered: