Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for showing the gem version with -v or --version. #101

Merged
merged 2 commits into from
Jul 19, 2023
Merged

Adding support for showing the gem version with -v or --version. #101

merged 2 commits into from
Jul 19, 2023

Conversation

brycethornton
Copy link
Contributor

@brycethornton brycethornton commented Jul 19, 2023 •
edited

Currently the -v and --version options don't actually show the version. Here's what you get:

% pg-online-schema-change --version
No value provided for required options '--alter-statement', '--dbname', '--host', '--username'

This PR maps the -v and --version options to the correct method:

% pg-online-schema-change --version
0.9.2

@brycethornton brycethornton marked this pull request as ready for review July 19, 2023 21:16
shayonj
shayonj approved these changes Jul 19, 2023
View reviewed changes
Copy link
Owner

@shayonj shayonj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! thanks

@shayonj
Copy link
Owner

shayonj commented Jul 19, 2023

happy to re-approve post lint fix

@shayonj shayonj merged commit 66c74a1 into shayonj:main Jul 19, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shayonj shayonj shayonj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@brycethornton @shayonj