Add foreign keys to parent during swap #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shayonj
force-pushed
the
s/fk-fix
branch
3 times, most recently
from
fce9b44
to
9715f11
Compare
jfrost
requested changes
Mar 13, 2022
Until now we were structuraly copying the primary table into shadow table. While doing so, we were also copying the FKs. This could lead to locks on other queries running on the primary/dependent table. This PR fixes it by not adding the FKs to the shadow table, but adding the FK to the parent table itself from the same transaction, during the swap with 'NOT VALID'. It then, after swap, validates all constraint on the self table (primary) and referential tables (other tables with FK of primary table). So that, no FK constraints are left in NOT VALID state. Add smoke tests using pgbench (--foreign-keys)
jfrost
approved these changes
Mar 13, 2022
|
Ready to merge when tests pass! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now we were structurally copying the primary
table into shadow table. While doing so, we were also
copying the FKs. This could lead to locks on other queries
running on the primary/dependent table during copy.
This PR fixes it by not adding the FKs to the shadow table (to avoid any locks during copy),
but adding the FK to the parent table itself from the same transaction,
during the swap with
NOT VALID. It then, after swap, validates all constrainton the self table (primary) and referential tables (other tables with FK of primary
table). So that, no FK constraints are left in
NOT VALIDstate.Add smoke tests using pgbench (
--foreign-keys)Fixes: #61 #59