Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: More information in the messages of PipelineApplicationError #27

Closed
shaypal5 opened this issue Mar 4, 2020 · 5 comments

Comments

@shaypal5
Copy link
Collaborator

shaypal5 commented Mar 4, 2020

At the moment, there is too little information in the messages of PipelineApplicationError.

Things that should be added:

  1. The type of the pipeline stage (so the name of the class).
    1.1. Actually, maybe the description?! :)
  2. The index in the pipeline (obviously only when part of a pipeline; requires catching and rethrowing at the pipeline level).
  3. The label of the pipeline stage, when Feature suggestion: Add stage labels #19 is implemented.
@humblefool1997
Copy link

@shaypal5 I would like to work on this issue

@shaypal5
Copy link
Collaborator Author

That's great! Go ahead. :)

@naveenkaushik2504
Copy link
Contributor

I'd like to work on this issue. Have gone through the code to make the necessary changes. Will submit a PR soon. Hope this functionality is still desired.

@shaypal5
Copy link
Collaborator Author

Great! Yeah, I'm still waiting for it. :)

naveenkaushik2504 added a commit to naveenkaushik2504/pdpipe that referenced this issue Aug 30, 2020
shaypal5 added a commit that referenced this issue Oct 1, 2020
@shaypal5
Copy link
Collaborator Author

shaypal5 commented Oct 6, 2020

Close with #38 !
Hooray @naveenkaushik2504 !

@shaypal5 shaypal5 closed this as completed Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants