Fix double counting of fatal failures #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veniosg
requested review from
AndreiZaitcev
and removed request for
fpezzato and
AndreiZaitcev
AndreiZaitcev
requested changes
Feb 19, 2019
fork-runner/src/main/java/com/shazam/fork/runner/listeners/ProgressTestRunListener.java
Show resolved
Hide resolved
|
Rolled back the version. Feel free to merge if you're covered with the retry logic. |
AndreiZaitcev
approved these changes
Feb 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fork was keeping wrong counts if a test was crashing as both testFailed and testRunFailed were being triggered but the code assumed only one would be.
The run results were correct as they are not tied to the counts but the reports themselves.