This repository has been archived by the owner on Jun 28, 2024. It is now read-only.
Performance #87
Merged
Performance #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ses. This can be replaced with the combination of package pattern and class pattern.
…and CLI configuration file.
…gin extension and CLI configuration file.
…ion and CLI configuration file.
…defaults to configuration builder rather than callers, for consistency.
…respective fields.
|
Closes #48. |
| AnnotationItem annotation) { | ||
| String testMethod = method.method.getMethodName().getStringValue(); | ||
| String testClass = getClassName(classDefItem); | ||
| boolean ignored = isClassIgnored(annotationDirectoryItem) || isMethodIgnored(annotation); |
There was a problem hiding this comment.
This ignored boolean might be wrong, as the previous filter in convertClassToTestCaseEvents removes anything but TEST_ANNOTATION. That said, no ignore annotation can be present here.
I think we can relax the filter in the method convertClassToTestCaseEvents to something like:
.filter(annotation -> (TEST_ANNOTATION.equals(stringType(annotation))
|| (IGNORE_ANNOTATION.equals(stringType(annotation)))))
to fix this.
There was a problem hiding this comment.
Good catch. I will add some unit tests to this class cause the dex data types is what confuses me. I think your recommendation would create multiple test cases for the same test though so it needs a bit thinking through.
|
Amazing! I left just a couple of very minor notes in the PR (a possible small bug and a question) Other than that: LGTM! 💯 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branch that contains chimprunner, which runs instrumentation-type tests and keeps timings.