Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add devcontainer and move test dependencies to dev deps #101

Merged

Conversation

jam-girl
Copy link
Contributor

Overview

Moved pytest and pytest-asyncioto dev dependencies. Added a dev container including ffmpeg so one could immediately be up and running with a compatible developer environment for this project.

Evidence

Screenshot 2024-03-31 at 12 49 55

@jam-girl
Copy link
Contributor Author

Apologies that this isn't an atomic PR and does two things, if you want me to break it up between the dependency move and the version upgrade and the devcontainer please let me know

@dotX12
Copy link
Collaborator

dotX12 commented Mar 31, 2024

I have never used the devcontainers tool, but if it is useful for you and other people for development, why not.

@dotX12
Copy link
Collaborator

dotX12 commented Mar 31, 2024

Apologies that this isn't an atomic PR and does two things, if you want me to break it up between the dependency move and the version upgrade and the devcontainer please let me know

Everything is fine)

@dotX12
Copy link
Collaborator

dotX12 commented Mar 31, 2024

I'll move this PR to dev2.0 (#100) as there are too few changes for 0.6.0, within a week there will probably be some code, then I'll move it to master and release it.

@dotX12 dotX12 changed the base branch from master to dev2.0 March 31, 2024 14:28
@dotX12 dotX12 merged commit cd73156 into shazamio:dev2.0 Mar 31, 2024
4 checks passed
@dotX12 dotX12 mentioned this pull request Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants