Fix top tracks, small refactoring. #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shazam has changed the contract for obtaining top songs: - Top tracks in country by genre - Top tracks in country - Top tracks in city - Top tracks in world by genre - Top tracks in world We managed to maintain this functionality, but the format of the responses has changed, as have the response models! Please make corrections, the data has changed significantly!!! Added `playlist` and `playlists` methods for Serialize.
|
Fix: #104 |
# Conflicts: # poetry.lock # pyproject.toml
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shazam has changed the contract for obtaining top songs:
We managed to maintain this functionality, but the format of the responses has changed, as have the response models! Please make corrections, the data has changed significantly!!!
Added
playlistandplaylistsmethods for Serialize.Minor fixes, corrected pydantic models, corrected song recognition test, because for some reason the song from dora.ogg disappeared from shazam (???).