Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to be able to add an iterator to the index queue instead of raw data #22

Closed
Shazwazza opened this issue Jun 24, 2015 · 2 comments
Closed
Milestone

Comments

@Shazwazza
Copy link
Owner

For example, when indexing thousands of items, it would be much better if we can queue up an iterator for the worker thread to process instead of queuing up already serialized items which can consume memory.

@Shazwazza
Copy link
Owner Author

So basically instead of this combination of methods:

 void AddNodesToIndex(IEnumerable<XElement> nodes, string type)

and

 void EnqueueIndexOperation(IndexOperation op)

we should be able to pass a callback or something to the IndexOperation so that it can resolve the XElement just before it indexes that way it won't consume memory in the queue.

@Shazwazza
Copy link
Owner Author

The AddNodesToIndex is fine, but internally added this method:

protected void EnqueueIndexOperation(IEnumerable ops)

and changed the blocking collection to work with batches.

@Shazwazza Shazwazza added this to the v0.1.66 milestone Jul 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant