Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept include_from_page_type config #39

Closed
wants to merge 4 commits into from

Conversation

lilireece
Copy link

In my case, I want to apply this module on one page type only. But there are many page types in my code base. I do not want to list them one by one in the exclude_from_page_type setting. So I added the include_from_page_type to make it flexible in different situations.

@scott1702
Copy link
Contributor

@lilireece Care to rebase? :)

@sheadawson
Copy link
Owner

@lilireece Sorry for the late response on this one. This would be a great addition to the module. I wonder if we could change the language slightly though as include_from_page_types doesn't sound quite right. Would you mind changing it to restrict_to_page_types? Or if anyone has any better suggestions let me know.

Ideally I think pagetype_whitelist and pagetype_blacklist would be the most clear and consistent. Maybe we could change to this while keeping backwards compatibility for exclude_from_page_types?

@lilireece
Copy link
Author

@sheadawson No worries. As long as we can use include page types, it would be convenient for those people with lots of page types.

@sheadawson
Copy link
Owner

Thanks guys, I've taken what you've done and implemented config options for pagetype_blacklist, pagetype_whitelist and legacy support for exclude_from_page_types

sheadawson added a commit that referenced this pull request Jun 21, 2016
* master:
  fix blocks tab not showing in some cases. Fixes #98
  implement pagetype_black/whitelist. Fixes #39
  update .editorconfig php use tabs not spaces
  Add translatbale gist to readme
  Remove validation on Block Title field
  Add scrutinizer badge
  Allow BlockAreaName translations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants