Make module functional with SS4 #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinglozzer
commented
Dec 4, 2018
| singleton('ShortcodableParser')->register($class); | ||
|
|
||
| $safeClassName = str_replace('\\', '_', $class); | ||
| ShortcodeParser::get('default')->register($safeClassName, array($class, 'parse_shortcode')); |
There was a problem hiding this comment.
The shortcode parser doesn’t like the \ in namespaced classes :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a project that’s short on time, so this is only the bare minimum functionality...
What’s working:
What’s not working (I assume, because I’ve not tested at all)
Lots of JavaScript that this module relied on (e.g. “dialog” stuff, htmleditorfield helpers) have been removed for SS4, so I literally copied and pasted a few chunks from SS3. Ideally this would be re-built as a React UI or something, but I’m not volunteering for that task 😉