Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix strict_strtoul for never kernels #172

Merged
merged 1 commit into from Sep 30, 2015
Merged

fix strict_strtoul for never kernels #172

merged 1 commit into from Sep 30, 2015

Conversation

vtolstov
Copy link
Contributor

strict_strtoul() was just a redefinition of kstrtoul() for a long
time. From kernel version of 3.18, strict_strtoul() will not be
defined at all. A compile time kernel version check is needed to
decide which function or macro can be used for a specific version of
kernel.

Signed-off-by: Vasiliy Tolstov v.tolstov@selfip.ru

@vtolstov
Copy link
Contributor Author

fixes #163

@marcin-github
Copy link
Contributor

Now sbd compiles fine (for me), thanks.

@vtolstov
Copy link
Contributor Author

nice to hear!

@mitake
Copy link
Contributor

mitake commented Sep 25, 2015

Could you fix the first line of the commit log like this:
sbd: fix strict_strtoul for newer kernels
?

strict_strtoul() was just a redefinition of kstrtoul() for a long
time. From kernel version of 3.18, strict_strtoul() will not be
defined at all. A compile time kernel version check is needed to
decide which function or macro can be used for a specific version of
kernel.

Signed-off-by: Vasiliy Tolstov <v.tolstov@selfip.ru>
@vtolstov
Copy link
Contributor Author

@mitake fixed

mitake added a commit that referenced this pull request Sep 30, 2015
fix strict_strtoul for never kernels
@mitake mitake merged commit 4aa4db4 into sheepdog:master Sep 30, 2015
@mitake
Copy link
Contributor

mitake commented Sep 30, 2015

Pulled, thanks.

@vtolstov vtolstov deleted the sbd branch September 30, 2015 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants