sheep/vdi: Fix fill_vdi_state_list() to set 'deleted' member #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Takashi Menjo <menjo.takashi@lab.ntt.co.jp>
The function fill_vdi_state_list() implementing SD_OP_GET_VDI_COPIES should set the 'deleted' member of struct vdi_state and respond it. This is mainly for sheep/group.c:get_vdis_from() because it set VDI bitmap 'sys->vdi_deleted' based on the value of 'deleted' member responded by SD_OP_GET_VDI_COPIES request. Signed-off-by: Takashi Menjo <menjo.takashi@lab.ntt.co.jp>
Fixes sheepdog#234 Signed-off-by: Takashi Menjo <menjo.takashi@lab.ntt.co.jp>
|
Merged, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function
fill_vdi_state_list()implementingSD_OP_GET_VDI_COPIESshould set thedeletedmember ofstruct vdi_stateand respond it.This is mainly for sheep/group.c:
get_vdis_from()because it set VDI bitmapsys->vdi_deletedbased on the value ofdeletedmember responded bySD_OP_GET_VDI_COPIESrequest.I separate my work into 3 commits. First one refactors related unit tests to use Unity framework. Second one adds unit tests. Third one fixes
fill_vdi_state_list().Fixes #234.