Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--only now requires full migration name #21

Closed
chadxz opened this issue Apr 3, 2018 · 1 comment · Fixed by #22
Closed

--only now requires full migration name #21

chadxz opened this issue Apr 3, 2018 · 1 comment · Fixed by #22

Comments

@chadxz
Copy link
Contributor

chadxz commented Apr 3, 2018

I recently upgraded from 1.5.1 to 1.5.4 and noticed that a command that i used to run, namely

knex-migrate up --only 20180315084901

Didn't run only that migration, but instead, ran all migrations. Upon investigating, I found that the following command does work:

knex-migrate up --only 20180315084901_create_rj_object

This was the full name of the migration, minus the .js extension.

I haven't investigated, but I'd be willing to bet that the umzug upgrade from ^1.11 to ^2.1 is the likely culprit

anyway, might be worth possibly releasing a new major version and deprecating 1.5.2, 1.5.3, and 1.5.4

@chadxz
Copy link
Contributor Author

chadxz commented Apr 3, 2018

looks like the cause is in commit b357f44 which means 1.5.2 is unaffected

chadxz added a commit to chadxz/knex-migrate that referenced this issue Apr 3, 2018
We were previously defining options to pass to minimist, but not passing
them in. This patch fixes that.

Fixes sheerun#21.
sheerun pushed a commit that referenced this issue Apr 4, 2018
We were previously defining options to pass to minimist, but not passing
them in. This patch fixes that.

Fixes #21.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant