Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #125

Open
wants to merge 32 commits into
base: master
Choose a base branch
from
Open

Conversation

ksmithut
Copy link

There are probably a lot of other pull requests updating dependencies. This is a comprehensive upgrade of all dependencies, which may not be desirable, but is there if you'd like it. It's definitely got breaking changes when it comes to node version compatibility. I ran tests against node 12 and up, and node 12 was getting memory allocation issues with a WASM module somewhere, but it worked node 14 and up.

Biggest changes include:

  • Moving to ESM
    • This was required by some dependencies like globby, find-up, and execa updating to the latest. I've been writing a lot of my side-project services in ESM and have quite enjoyed it, and now that it's supported by all current LTS versions of node, I think it was a good move. Especially easy for this smallish project.
  • Some additional prettierx options to be more in line with standard

It seems like this module has been abandoned, and that's okay :) I fully intend to keep my fork up to date and published and use mine until I change my formatting/linting preferences change. This PR is meant to be the changes necessary to update the dependencies at this point in time. I'm going to merge this into my base branch and make additional changes to CI configuration, package naming and other things to make this publishable by itself. I don't anticipate having to keep this up to date with the upstream because there hasn't been any work done to keep it up to date in over a year. Which, again, is totally fine :) My fork may fall into the same state when my preferences change, or a majority of my work starts to focus more in non-javascript projects.

@ksmithut
Copy link
Author

Also, for what it's worth, if dependencies get updated (even less aggressively than this Pull Request), I'm happy to close this out. I just did some work on my fork to get my project dependencies out of the "audit hot zone". Happy to relinquish my fork once this project is back on track.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant