Make error pages dynamic and customizable #26

Closed
sheerun opened this Issue Aug 16, 2013 · 3 comments

Projects

None yet

1 participant

Owner
sheerun commented Aug 16, 2013

http://railscasts.com/episodes/53-handling-exceptions-revised

Reasoning

  • Almost every Rails app I know leaves default error pages, which is a shame.
  • In my experience when it comes to implementing custom error pages they are written in plain html and put in public, and after that completely forgotten, differing more and more from layout design.
  • For 500 API calls, the public/500.html is rendered by default. What should render is JSON with error message.

The solution is to define explicit controller for handling exceptions. That way you can use site layout template, SLIM, rails helpers etc. In general error pages become more dynamic.

Possible downsides

Error handling deadloop (error is thrown from error controller). I'll try to implement some safeguard for this case though. I think of fallback to public/500.html when there is an exception thrown in errors controller.

Also, to prevent such cases I think ExceptionsController should inherit directly from ActionController::Base, instead of ApplicationController. That should protect it from programming errors committed in ApplicationController.

Owner
sheerun commented Aug 18, 2013

For not I cannot find any gem for it. The solution is easy enough to be implemented directly imho.

@sheerun sheerun closed this in cf7bada Aug 18, 2013
@sheerun sheerun added a commit that referenced this issue Aug 18, 2013
@sheerun sheerun Dynamic error pages, closes #26 5c2df5a
Owner
sheerun commented Aug 18, 2013

Final decisions

  • Error pages in /public removed all together
  • It turned out Rails 4 has safeguard against dead-loops in exceptions_app
  • Error pages look just like Rails' defaults, but implemented using layout and templates
  • Applications searches for error template in errors/500.slim or similar, and fallbacks to errors/show.slim
  • The rest is implemented just as on RailsCast
Owner
sheerun commented Oct 16, 2013

Tested for interoperation with Sentry (Raven) and error logging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment