Make syntax concealing optional for JSON + Markdown.

[robhurring]

Allow users to toggle concealing off for JSON and Markdown using the following new options:

" turn off JSON conceal *mirrors vim-json's setting
let g:vim_json_syntax_conceal = 0

" turn off Markdown conceal
let g:vim_markdown_syntax_conceal = 0

Default is on, so should have the same expected behavior OOB. I can add more options for other languages, but these were the 2 that affected me personally.

[sheerun]

You need these patches against upstream repositories. vim-polyglot just gathers plugins together.

[robhurring]

Fair enough. For the JSON syntax, the upstream already has this functionality (here but not in your fork), I was trying to back-port to here since I wasn't sure how you were handling the syntax files.

The markdown I can definitely put a PR against the main repo.

[ahmedelgabri]

Any updates on this?

[robhurring]

This was merged into tpope/vim-markdown#99. It should be available here next update. (Not sure what the cycle for that is)

[ahmedelgabri]

What about JSON? since the upstream plugin already supports the option to disable this?

[robhurring]

Same deal, next pull from upstream should bring this functionality in. @sheerun would you be able to update the json and markdown packages for us?

Also worth noting, in the https://github.com/tpope/vim-markdown/pull/99/files I renamed the setting to let g:markdown_syntax_conceal = 0 to be more consistent within the package itself, and not what this PR mentions at the top.

[ahmedelgabri]

Thanks @robhurring

[sheerun]

I've pushed updated build

[robhurring]

@sheerun your sheerun/vim-json repo looks out of date from its upstream (elzr/vim-json) which has those settings so the g:vim_json_syntax_conceal setting never made it in.

[sheerun]

that's because I want to keep conceal off by default (I removed concealing in my fork)

[sheerun]

See: elzr/vim-json#59

[robhurring]

Whoops. Missed that part -- 💯 agree, concealing is obnoxious IMO.

[ahmedelgabri]

For some reason I still can't disable concealing in .json files, I see that you disabled it here sheerun/vim-json@fe4596e and I do have this in my .vimrc but still it's not disabled.

[sheerun]

Maybe you're using different plugin? Could you post your .vimrc somewhere?

[ahmedelgabri]

Not the most organized but here you go https://github.com/ahmedelgabri/dotfiles/blob/master/vim/vimrc.local#L60 the other json plugin is already commented out.

[ahmedelgabri]

@sheerun I think I had a problem with my tmux session, not sure how. But it works now. Thanks & sorry for the false alarm.