Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSX still syntax highlighted when disabling typescript #414

Closed
drewschrauf-myob opened this issue Jun 23, 2019 · 3 comments
Closed

TSX still syntax highlighted when disabling typescript #414

drewschrauf-myob opened this issue Jun 23, 2019 · 3 comments

Comments

@drewschrauf-myob
Copy link

Describe the bug:

I use yats for syntax highlighting typescript and polyglot for all other languages. Until recently, setting let g:polyglot_disabled = ['typescript'] was enough to disable polyglot's detection of typescript.

TSX files have started seeing syntax highlighting issues. Upon investigation, this file appears to get loaded for typescript and requires the disable flags to be updated to let g:polyglot_disabled = ['typescript', 'jsx'].

I don't know enough to understand whether that's intentional or is a copy/paste issue from its javascript counterpart. The comment block at the top refers to javascript.jsx so I suspect it's the latter.

To Reproduce:

Set let g:polyglot_disabled = ['typescript'] and load a TSX file. JSX and styled-components regions are still highlighted.

@sheldonkwok
Copy link

This is breaking my regular typescript files as well.

@sheldonkwok
Copy link

This is fixed in #419

@sheerun sheerun closed this as completed in ae18284 Sep 4, 2019
@sheerun
Copy link
Owner

sheerun commented Sep 4, 2019

I fixed it properly..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants