-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node 16.x is supported? #275 #42
Comments
Have you tried downgrading? Did it work? Going to try with 14 and see if it fixes the issue 🤔 UPD: Looks like it worked. At least no missing libs issue anymore. But now I have browser hanging :D Fun |
Right, this layer depends on https://github.com/alixaxel/chrome-aws-lambda and the upstream repo hasn't been updated to support Node 16 yet. I see @outaTiME already raise the issue there: alixaxel/chrome-aws-lambda#275 |
I've just published a new layer version 27 that has the latest Chromium and Node 16 support! Thanks again for pointing this out! |
Hi @vladgolubev,
but if I manually download and configure the artifact (https://github.com/Sparticuz/chrome-aws-lambda/suites/6829349165/artifacts/263061533) it works like a charm, could it be that you have left some misconfigured route when you did the deployment? |
@outaTiME hm, strange, what I did is just package the same artifact zip as is into a layer Maybe it's b/c zip has extra I've just published v28 with that change, could you please try it ? |
Unfortunately using 28 throws the same error, locally my structure for the layer is as follows:
the error message gives the feeling that the and as I told you before, I simply unzipped the artifact in a folder called "chrome": I also tell you that I am using SST, I show you a little about the definition of my layer: const layerArn =
"arn:aws:lambda:us-east-1:764866452798:layer:chrome-aws-lambda:28";
socialNotify: {
function: {
handler: 'src/subscribers/social-notify.handler',
bundle: {
externalModules: ['@sparticuz/chrome-aws-lambda'],
},
layers: [
new lambda.LayerVersion(stack, 'ChromeLayer', {
code: lambda.Code.fromAsset('packages/api/layers/chrome'),
}),
// commented out to leave the local layer which is the one that works
// LayerVersion.fromLayerVersionArn(stack, "ChromeLayer", layerArn),
],
// ~30s
timeout: '1 minute',
},
cdk: {
subscription: {
filterPolicy: {
event: SubscriptionFilter.stringFilter({
allowlist: ['social-notify'],
}),
},
},
},
}, |
So apparently, embedding I'm not familiar with SST so maybe the issue is with it somehow? |
Regardless of SST and the layer has to have the following structure
and looking at the contents I see that the btw, you can also see some dirt in the zip, like the descriptors (__MACOSX) which can possibly be removed to make everything much cleaner |
@outaTiME what about layer version 29? it should have the Thanks for pointing out the dirt. I can see that + some other stuff to be removed (like |
yay, @vladgolubev, the layer 29 works amazing 🚀 Thank you very much, for all your work and support !!! |
You're welcome! And thank you too! v30 w/o junk (~2 MB of junk removed) will be published as soon as Docker Hub will get up 🙂 |
Great, I'm trying a new layer 30 as soon as it's available, thanks again !!! |
I just downloaded layer 30, and I keep seeing dirt in the |
Automated zipping via create-zip.sh as turns out macOS will create that junk if you zip from UI. Now it shouldn't be! I've published v31 and I don't see any that junk anymore! |
sweet, everything works amazing, thanks again @vladgolubev !!! |
I am having the following error when I try to run my lambda with node 16.x, does anyone else get this?
The text was updated successfully, but these errors were encountered: