Avoid jest watch race condition #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skips waitForLocalhost if dynamodb-local is already running. Fixes shelfio#112
randomhash
reviewed
Oct 1, 2021
| @@ -70,7 +73,5 @@ async function createTables(dynamoDB, tables) { | |||
| } | |||
|
|
|||
| async function deleteTables(dynamoDB, tableNames) { | |||
| return Promise.all( | |||
| tableNames.map(tableName => dynamoDB.deleteTable({TableName: tableName}).promise()) | |||
There was a problem hiding this comment.
Hey! Thank you for your contribution.
Why do you want to remove .promise() here?
There was a problem hiding this comment.
@randomhash Thanks for reviewing! .promise() failed for me because jest-dynamodb uses AWS SDK v3 but .promise() is only part of the AWS SDK v2 API.
.promise() is required with v2 because deleteTable v2 returns an AWS.Request with a promise method that must be called. Instead, in v3 deleteTable returns a Promise.
Also see the Migrating to AWS SDK v3 guide which includes an example of removing .promise() calls when upgrading to AWS SDK v3.
|
Hi, could this be merged? This bug is really slowing us down in development as --watch is unusable currently. |
vladholubiev
approved these changes
Dec 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #112