refactor(ui): remove unnecessary store and hooks related to mobile detection #2838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gustavosbarreto
force-pushed
the
feat/improve_navigation_drawer
branch
2 times, most recently
from
e26418b
to
1b68765
Compare
gustavosbarreto
changed the title
…tection * Removed a complex store that was used to determine if the browser is mobile or not, which involved a hardcoded window width check. Instead, I integrated the `useDisplay` composable from Vue to accurately determine if the screen size is "lgAndUp" to display the sidebar accordingly. This approach is more robust and reliable compared to relying on a hardcoded value. * Removed a bunch of hooks that were triggered by the browser's onResize event to track window resizing. I also eliminated store-related code related to the sidebar's state, which was primarily used for toggling the sidebar when in mobile view. Additionally, I made the `<AppLayout>`, pass the sidebar's visibility model to the `<AppBar>` component using the new `defineModel` feature of Vue 3.3. As part of the refactoring, I also converted several components to use `<script setup>`, which offers a much cleaner code structure compared to defineComponent usage style.
gustavosbarreto
force-pushed
the
feat/improve_navigation_drawer
branch
from
1b68765
to
8d2168f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.