Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/login component and new test #2851

Merged
merged 1 commit into from
Jun 12, 2023
Merged

Fix/login component and new test #2851

merged 1 commit into from
Jun 12, 2023

Conversation

luannmoreira
Copy link
Member

  • fix(ui): login component refactored
  • wip: help needed

@luannmoreira luannmoreira added help-wanted Extra attention is needed area/ui do-not-merge status/work-in-progress javascript Pull requests that update Javascript code kind/refactor labels May 30, 2023
@luannmoreira luannmoreira self-assigned this May 30, 2023
@luannmoreira luannmoreira requested a review from a team as a code owner May 30, 2023 12:52
@luannmoreira luannmoreira changed the title Fix/ login component and new test Fix/login component and new test May 30, 2023
otavio
otavio reviewed May 30, 2023
View reviewed changes
ui/src/views/Login.vue Outdated
@@ -110,9 +112,9 @@ export default defineComponent({
const route = useRoute();
const router = useRouter();
const snackbar = useSnackbar();
const isCloud = computed(() => envVariables.isCloud);
const cloudCheck = isCloud();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isCloudEnvironment

@luannmoreira luannmoreira requested review from a team as code owners June 5, 2023 20:32
@luannmoreira luannmoreira force-pushed the fix/login branch 4 times, most recently from 3007cb7 to 29b9343 Compare June 12, 2023 15:14
@gustavosbarreto gustavosbarreto merged commit b2361b5 into master Jun 12, 2023
7 checks passed
@gustavosbarreto gustavosbarreto deleted the fix/login branch June 12, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@otavio otavio otavio left review comments

Assignees

@luannmoreira luannmoreira

Labels
area/ui do-not-merge help-wanted Extra attention is needed javascript Pull requests that update Javascript code kind/refactor status/work-in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@luannmoreira @otavio @gustavosbarreto