-
-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: namespace's connection announcement #3508
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heiytor
force-pushed
the
feat/namespace-connection-announcement
branch
12 times, most recently
from
February 5, 2024 21:13
2f2f1dd
to
a61a4ae
Compare
heiytor
force-pushed
the
feat/namespace-connection-announcement
branch
6 times, most recently
from
February 6, 2024 15:40
a832105
to
62d9d17
Compare
otavio
reviewed
Feb 6, 2024
henrybarreto
previously approved these changes
Feb 7, 2024
Please fix CI issues. |
heiytor
force-pushed
the
feat/namespace-connection-announcement
branch
from
February 7, 2024 18:38
5d242bf
to
5e34fab
Compare
Fixed! It was an mock interface issue. |
henrybarreto
previously approved these changes
Feb 7, 2024
luannmoreira
force-pushed
the
feat/namespace-connection-announcement
branch
3 times, most recently
from
February 8, 2024 13:06
246858d
to
f2a7369
Compare
heiytor
force-pushed
the
feat/namespace-connection-announcement
branch
5 times, most recently
from
February 9, 2024 19:04
c41fcfd
to
b43a0ce
Compare
otavio
requested changes
Feb 9, 2024
heiytor
force-pushed
the
feat/namespace-connection-announcement
branch
from
February 9, 2024 19:56
b43a0ce
to
d0a2805
Compare
heiytor
force-pushed
the
feat/namespace-connection-announcement
branch
2 times, most recently
from
February 9, 2024 20:02
e820e96
to
c0decf3
Compare
luannmoreira
force-pushed
the
feat/namespace-connection-announcement
branch
from
February 9, 2024 21:11
c0decf3
to
1d18984
Compare
The connection announcement of a namespace is a custom UTF-8 valid string provided by the user, with a maximum length of 127 characters, which which can be written in a SSH session. The SSH server must decide when to write this message in an established connection and must skip this stage if the connection announcement is an empty string. A user can set the connection announcement by making a PUT request to the existing `/api/namespaces/:tenant` route. The announcement must leave under's `settings.connection_announcement` body: A user can set the connection announcement by making a PUT request to the existing `/api/namespaces/:tenant` route. The announcement must be placed under the `settings.connection_announcement` field: ```json { "settings": { "connection_announcement": "My awesome connection announcement" } } ``` > NOTE: An empty string can be sent in this request to disable this feature. To retrieve the announcement, users can make a GET request to `api/namespaces/:tenant`, where the announcement will be available in `settings.connection_announcement`. To retrieve the announcement, users can make a GET request to `api/namespaces/:tenant`, where the announcement will be available in `settings.connection_announcement`. There are also two important things to notice: 1. A new method `NamespaceLookup` is introduced in the internal client, which can help the SSH session retrieve the connection announcement. The server must decide when to write this message in the session. 2. A new migration with ID 64 is added to automatically set the connection announcement to an empty string for already existing namespaces.
This commit is aimed to add the interface and unitary tests of the new feature connection announcement.
heiytor
force-pushed
the
feat/namespace-connection-announcement
branch
from
February 9, 2024 21:29
1d18984
to
40dd6e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The connection announcement of a namespace is a custom UTF-8 valid
string provided by the user, with a maximum length of 127 characters,
which which can be written in a SSH session.
The SSH server must decide when to write this message in an established
connection and must skip this stage if the connection announcement is an
empty string.
A user can set the connection announcement by making a PUT request to
the existing
/api/namespaces/:tenant
route. The announcement mustleave under's
settings.connection_announcement
body:A user can set the connection announcement by making a PUT request to
the existing
/api/namespaces/:tenant
route. The announcement must beplaced under the
settings.connection_announcement
field:To retrieve the announcement, users can make a GET request to
api/namespaces/:tenant
, where the announcement will be available insettings.connection_announcement
.To retrieve the announcement, users can make a GET request to
api/namespaces/:tenant
, where the announcement will be available insettings.connection_announcement
.There are also two important things to notice:
A new method
NamespaceLookup
is introduced in the internal client,which can help the SSH session retrieve the connection announcement.
The server must decide when to write this message in the session.
A new migration with ID 64 is added to automatically set the connection
announcement to an empty string for already existing namespaces.
Progress: