fix: device list acceptable wrong status #3547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrybarreto
force-pushed
the
fix/device_list_acceptable_no_status
branch
3 times, most recently
from
8dc41f1
to
b6792d3
Compare
henrybarreto
force-pushed
the
fix/device_list_acceptable_no_status
branch
3 times, most recently
from
b2fa3d4
to
9772b9a
Compare
henrybarreto
added
status/needs-review
status/require-tests
and removed
do-not-merge
status/require-tests
labels
henrybarreto
force-pushed
the
fix/device_list_acceptable_no_status
branch
4 times, most recently
from
2372a0b
to
69f5bcd
Compare
When listing devices with a non empty status, i.g `accepted`, `pending`, the `acceptable` field was right defined. However, if it is set to empty, no logic was applied, setting the field to `false`, the default value in Go. To solve the issue, we evaluate the `acceptable` field based on devices in `removed_devices`, for cloud instances, its `accepted` status when it is already `accepted` and when the namespace has a limit defined. Fixes: #3527
henrybarreto
force-pushed
the
fix/device_list_acceptable_no_status
branch
2 times, most recently
from
b07d854
to
bb69ac0
Compare
henrybarreto
force-pushed
the
fix/device_list_acceptable_no_status
branch
from
bb69ac0
to
d65c5e7
Compare
henrybarreto
force-pushed
the
fix/device_list_acceptable_no_status
branch
from
d65c5e7
to
f07fa6d
Compare
otavio
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.